🐛 Error when trying to submit an argument about rfc-vote HOT 9 CLOSED

@SerhiiCho One thing though, not sure if this issue should be labeled as a bug, because the feature works, is just that you need to have the environment properly set up and it works as expected. I think this issue is more about us defining all the ways you can start this project locally and work based on your machine, and improve the docs a bit so that users who are willing to contribute to this project ca do so relatively easy. Unfortunately I don't have access to a Mac laptop, therefore I would need some help with that part.
@Erol314 As you mentioned here that you are going to give this project a try on m2 mac, could you please also have a look at this https://patrickwthomas.net/macos-docker/, it would be nice if this works well because it will simplify a lot the sail setup.

from rfc-vote.

Makes sense

from rfc-vote.

Just FYI, setting BROWSERSHOT_FAKE=true in your .env will skip all the image rendering and get rid of this error.

from rfc-vote.

@SerhiiCho, Unfortunately I didn't have time to look at this, basically this line works for all devices expect for the arm ones, in your case Mac m1.
Basically you need chrome or chromium for browsershot which is used in a job to generated the meta image.

The fix would be somewhat similar to what was suggested here somehow we need to specify what package to install based on cpu arhitecture, I think for mac m1,m2 chromium is needed, we could decide to use only chromium. Maybe if we only use chromium it will be a bit simpler to handle this.

I'll try to have a look at it today if I have time.

from rfc-vote.

@SerhiiCho have you tried to install Rosetta 2? apparently this will allow you to run x86 docker images, please have a look here
https://docs.docker.com/desktop/install/mac-install/ here is another link or more info on this https://patrickwthomas.net/macos-docker/

I you haven't installed Rosetta yet, please try installing it then make sure that you revert any changes made to this file https://github.com/brendt/rfc-vote/blob/main/docker/8.2/Dockerfile so that it installs chrome(this will not install chrome directly in your machine, meaning it will only run inside docker container)

from rfc-vote.

To vote for RFC, people need to install extra packages? Or is it just in Docker?

from rfc-vote.

Only for docker dev mode, in production is something else, and I think @brendt takes care of that. But locally with docker is a bit more complicated, and if I understand well from the linked articles Rosetta 2 will simplify a bit all of that because it will allow you to run docker images that are not specially built for arm.

from rfc-vote.

Unfortunately I didn't have time to look at this

No worries, I'll ditch Sail for now, it's causing too much issues for me. I'll use it locally with artisan serve

from rfc-vote.

Unfortunately I didn't have time to look at this

No worries, I'll ditch Sail for now, it's causing too much issues for me. I'll use it locally with artisan serve

Sure, you can work on this project without docker as well, maybe that is even better for you as far as dev experience goes.
Personally I like working with docker, but this is a personal preference. :)

from rfc-vote.