Git Product home page Git Product logo

Comments (5)

breard-r avatar breard-r commented on July 1, 2024 1

Downloading the full certificate chain is already the default behavior, you don't need to manually include any intermediate certificate. In RFC 8555, this is specified in section 7.4.2 and section 9.1. However, you are right to bring this topic since I forgot to explicitly set the Accept HTTP header to application/pem-certificate-chain. But please note that it will not be fixed quickly since I am currently doing a quite heavy refactoring of both the HTTP and the threads parts in order to remove the nasty coupling between these two.

I don't know much about Dehydrated's internals, but I really would like to hear more about the rationale behind this walk_chain function.

from acmed.

breard-r avatar breard-r commented on July 1, 2024 1

It might be required in cases where the server does not automatically return the proper certificate chain, but in the case of Nginx that seems to be handled automatically.

That would be an issue with the server, not the client. For "exotic" cases, I think a solution based on hook like you did is the way to go.

After a long and motivation-less refactoring work, the missing Accept HTTP header with the application/pem-certificate-chain value has finally been added in 26ce6fd. I guess I can close this issue now.

from acmed.

dbrgn avatar dbrgn commented on July 1, 2024

What I'm using right now:

[[hook]]
name = "build-fullchain"
type = ["file-post-create", "file-post-edit"]
cmd = "cat"
args = ["{{file_path}}", "/etc/acmed/cert.int-x3.letsencrypt.org.pem"]
stdout = "{{file_directory}}/{{file_name}}.chain.pem"

...however, the intermediate is static.

from acmed.

dbrgn avatar dbrgn commented on July 1, 2024

Ah, you are right, appending the intermediate does not seem to be necessary 🙂 I just assumed it was because Dehydrated creates these files.

It might be required in cases where the server does not automatically return the proper certificate chain, but in the case of Nginx that seems to be handled automatically.

from acmed.

dbrgn avatar dbrgn commented on July 1, 2024

Thank you!

from acmed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.