Comments (6)
@OmarShezan I have updated the ESLint config file and fixed most of the warnings that could automatically be fixed. You should now be able to use ESLint to see most of the issues. DeepScan also runs its own rule set when merged which are un-related to ESLint which you will need to go to DeepScan to see, or install the DeepScan plugin in whatever Code Editor you are using.
As of now, all the errors/warning are related to ESLint and not DeepScan, so just calling npx eslint .
should mostly do the trick.
from binari.
@vsan626 Go ahead and create a PR with the updated .eslintrc.js file and if the warnings go away, then great! Otherwise, we can work from there and see what needs to be fixed. I was aware of the React version warning, but decided to leave it to newcomers to fix (:
In the DeepScan score found here we can also see that there are two no-console warnings that you can also fix if you would like. After that I think that Binari's score should increase in the eyes of DeepScan; at least for now. There will definitely more warnings and errors to fix in the future as well.
Once you create a PR and will review and merge as soon as possible.
Thanks!
from binari.
is there a way to run DeepScan before creating a pull request? because at that point it's too late as ill have to delete my pull request and create a new one.
from binari.
After cloning this repo and running the code I see several warnings. When I run npx eslint . there was initially a warning saying React version was not specified, so I updated the .eslintrc.js file with the settings to fix that. After running npx eslint . again, no errors / warnings show up. Would the bugs / fixes that need to be handled come from the initial running of the code?
from binari.
I updated the About.js file by removing the console.log & changing the console.log inside the catch block to console.error. Noticed there may still be a warning with console.error after making a PR. Next idea would be to disable eslint's no-console within the About.js file.
from binari.
Hey , im a beginner and would love to contribute to this issue, can I be assigned for this?
from binari.
Related Issues (20)
- Add an expand/hide button on the lesson screen HOT 8
- Optimize the p5.js HOT 1
- Design terminals. HOT 9
- Binary tree crashes when a null value is inserted to the tree. HOT 3
- Add Call-To-Action button to landing page HOT 7
- Replace Landing page video HOT 1
- About page crashes on load HOT 1
- Create Hotkeys HOT 2
- Add Color Scheme to Directory HOT 2
- Move functions to helper.js files HOT 12
- Quick tutorial HOT 9
- Create Logo HOT 4
- Fix bug when running code through hotkey HOT 6
- Empty states are not handled in about page contributors card HOT 2
- The project description, documentation and home page states "dynamic programming" which is a misleading term. HOT 3
- The console could be made vertically resizable. HOT 3
- There is a grammatical mistake in chapter one(insertion) HOT 4
- Add test cases for react components HOT 9
- Running script before each commit to auto format and test HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from binari.