Git Product home page Git Product logo

Comments (6)

ibihim avatar ibihim commented on August 26, 2024 1

In the context of the original image, yes, there is just one, but a lot of organizations repackage the project AFAIK.
Also I would bind myself to an image / distro. I am really hesitant about that. I gave the example of mkcert as I was curious how they manage different possibilities.

E.g. bitnami uses mini-debian? kubebuilder seems to do some repackging too? Red Hat uses a RHEL image.

I can reach out for a second opinion to other maintainers.

from kube-rbac-proxy.

ibihim avatar ibihim commented on August 26, 2024

Wouldn't it be better to specify --oidc-ca-file=/etc/ssl/certs/ca-certificates.crt?

This is also a very specific path: There are at least 4 different paths in Linux distributions.

I am not completely convinced that the added complexity is worth it, but I might be missing context.

from kube-rbac-proxy.

nickytd avatar nickytd commented on August 26, 2024

The default location is based on the base image gcr.io/distroless/static:nonroot. I guess mkcert needs to consider all those options as it shall run/support different env. In the case here, the base image is not a moving part or at least we know the exact env on which the kube-rbac-proxy needs to run. It can check a set of 'default' locations but we always know which one will be used at the end. IMHO it is a fair trade off.

from kube-rbac-proxy.

nickytd avatar nickytd commented on August 26, 2024

Yep it is a valid case. Different distributions manage the case differently. Just for a reference here are some links:

  • RedHat
  • Debian
  • openSuSE
    Probably these locations can also change with new releases, but still a set of default locations can be compiled, taking care for the majority of the cases. No objections at all.

from kube-rbac-proxy.

ibihim avatar ibihim commented on August 26, 2024

I talked to @s-urbaniak and he wasn't convinced either. I hope you are not disappointed.

Thx for your frequent contributions.

from kube-rbac-proxy.

nickytd avatar nickytd commented on August 26, 2024

@ibihim No not at all. The project owners/maintainers decide on if or how to solve cases.

from kube-rbac-proxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.