Hiding Overflow on Site Content is not needed and has unpredictable consequences about astra HOT 5 CLOSED

overflow-x is not a problem, overflow-y: hidden messes up everything! :)

from astra.

Hello @actual-saurabh,

Firstly, Thank you very much for this Issue and the PR.

You are right, overflow: hiddendoes cause some unintended problems. Like we faced problems when adding compatibility for Divi.
I will check some earlier logs on to why this was added as this exists from the very early days of Astra.

from astra.

The blame shows that this was added in 6584757 in early Nov 2017 by @sandeshjangam

I guess they can weigh in if there's a specific reason that we're missing before you close this.

from astra.

It seems this CSS was added early on as a compatibility fox for animation effects for Visual Composer and it's addons. When the animations appear on page, it was adding horizontal scrolls to the screen.

I tested this once again and this no longer seems to be an issue anymore and this CSS can be removed.

Thank you very much for this PR @actual-saurabh 👍

from astra.

Hey @actual-saurabh you had a contributon in removing this CSS .
I just wanted to inform you that overflow-x:hidden needs to be added for another problem here for gutenberg compatibility. We did search multiple ways to overcome this although for now that seems the only solution at the moment.

Feel free to reply if you have any comments regarding this.

from astra.