Git Product home page Git Product logo

Comments (5)

kamesdev avatar kamesdev commented on August 26, 2024 1

1 BUG FIXED
In order to solve this problem you should add
dispatch(getUserDetails('profile'))
to submitHandler in UserEditScreen

2 BUG FIXED
In order to solve this problem you should add
dispatch(listProductDetails(productId))
to submitHandler in ProductEditScreen

from proshop_mern.

basir avatar basir commented on August 26, 2024 1

hello there
thanks for finding bugs but it is not a fix. you should not dispatch(getUserDetails('profile')) on submitHandler because in the submitHandler we did not update user or product yet.
will fix the issues soon and let you know on this thread.

from proshop_mern.

aorelhas avatar aorelhas commented on August 26, 2024

#1
If admin goes to /admin/user/:id/edit, click update and go to own profile /profile, then name and email is filled by other user data
e.g Instead of admin name there is John Doe and instead of [email protected] there's [email protected]

#2
If admin goes to (/admin/product/:id/edit), change some values e.g. name of product, click Update, and again click to edit the same product then there's not updated version of product

For your point one, you should add:

dispatch({ type: USER_DETAILS_RESET })

userActions.js > updateUser > after dispatch dispatch({ type: USER_DETAILS_SUCCESS, payload: data })

from proshop_mern.

aorelhas avatar aorelhas commented on August 26, 2024

#1
If admin goes to /admin/user/:id/edit, click update and go to own profile /profile, then name and email is filled by other user data
e.g Instead of admin name there is John Doe and instead of [email protected] there's [email protected]

#2
If admin goes to (/admin/product/:id/edit), change some values e.g. name of product, click Update, and again click to edit the same product then there's not updated version of product

For your point 2, you should add:

dispatch({ type: PRODUCT_DETAILS_SUCCESS, payload: data })

productActions.js > updateProduct > after dispatch dispatch({ type: PRODUCT_UPDATE_SUCCESS, payload: data })

from proshop_mern.

basir avatar basir commented on August 26, 2024

Fix 1:
https://github.com/bradtraversy/proshop_mern/pull/62/files#diff-a0edea66e0409c53c55788399e0f912434ca3497644c9ce349243ab149286067R43

Fix 2:
https://github.com/bradtraversy/proshop_mern/pull/62/files#diff-8bfc6d95272f3175c49db7886c7e0f68e1fd61030ce9a1c59bbb09e6df374e2aR173

from proshop_mern.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.