Some polish suggestions about sentry-vsts HOT 5 CLOSED

okay those are done, commit 0420b99

from sentry-vsts.

working on these - got the top 3 done just wiring up the last one as well. Thanks for the finds/suggestions 🥇

from sentry-vsts.

On second thought, maybe the last thing on your list is a symptom of another issue:

This plugin only has the ('create') ability as dictated in lines 17 and 18 of plugin .py

class VstsPlugin(CorePluginMixin, IssuePlugin2):
    allowed_actions = ['create']

The default for IssuePlugin2 is ('create', 'link', 'unlink') which I overrode to only 'create'.

So there are two options, either implement the link/unlink functionality, or hide the "Visual Studio Team Services" button when the only allowed_actions element is 'create'.

What is the intended purpose of the link/unlink functionality for an IssuePlugin2? It seems like it would be rather counter-intuitive for a VSTS plugin to implement that so I'd rather just hide the "Visual Studio Team Services" button for this particular plugin unless you guys have qualms about that?

Would an 'unlink' functionality simply delete the work item that was created in VSTS?

For our team's purposes, we thought it would make sense to only have a create functionality. Once work items are created in VSTS (ie the 'create' issue functionality) they would be decoupled from Sentry.io at that point.

from sentry-vsts.

My mistake... you can just add unlink to allowed_actions and sentry will handle unlinking. It does not require deleting the Work Item from VSTS, it simply unlinks it from sentry side.

I'm not familiar with VSTS, but will users recognize the acronym? The button currently is pretty wordy:

from sentry-vsts.

okay cool, I will add it.

I believe the acronym would be fine. I'll change that now.

from sentry-vsts.