Git Product home page Git Product logo

Comments (6)

felipecrs avatar felipecrs commented on August 17, 2024 1

@caleblloyd so sorry, but I didn't understand much of your reply.

I'm back to say that, if a group is required to be present you can ensure its presence with docker run --group-add <group-name>, in my case docker run --group-add=docker.

from fixuid.

molohov avatar molohov commented on August 17, 2024 1

This issue is still present.
Even if user is part of secondary groups in /etc/group, the user's groups only reflect what is set in /etc/fixuid/config.yml. You can verify this by running groups
Running with @felipecrs workaround will make the group present in the output of groups

from fixuid.

caleblloyd avatar caleblloyd commented on August 17, 2024

Secondary groups are specified in /etc/groups in the 4th column, which is referenced by username

In the case the container is run with the UID of an existing user that does not match the name of the configured fixuid user, the UID is not changed, so secondary groups will not match:

fixuid/fixuid.go

Lines 138 to 147 in 4467c25

} else {
oldUID = ""
newUID = ""
if existingUser == containerUser {
logInfo("runtime UID '" + runtimeUID + "' already matches container user '" + containerUser + "' UID")
} else {
logInfo("runtime UID '" + runtimeUID + "' matches existing user '" + existingUser + "'; not changing UID")
needChown = true
}
}

But in the typical case that the container is run with a UID that does not match any user in /etc/passwd, the UID of the configured fixuid user will be changed, but the secondary groups from /etc/group will still match, since they are referenced by username

from fixuid.

aigarius avatar aigarius commented on August 17, 2024

The problem lies in the ExitOrExec function that is executing the next process after doing all the changes. It is setting the euid and egid, but not looking up and setting additional groups from /etc/group from inside the container.

from fixuid.

caleblloyd avatar caleblloyd commented on August 17, 2024

@aigarius good catch - it was not recomputing /etc/passwd and /etc/group - opened #37 to address

from fixuid.

felipecrs avatar felipecrs commented on August 17, 2024

With this fix I was able to greatly simplify fixdockergid and drop the dependency on setpriv for it. Thanks a lot!

felipecrs/fixdockergid@ce80584

from fixuid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.