Following your suggestion I've added an icon to my exe file. It would be nice to also

Suggestion: Ability to add a top left/tab icon about web-view HOT 3 OPEN

boscop commented on September 3, 2024 1

Suggestion: Ability to add a top left/tab icon

from web-view.

Comments (3)

Jonesey13 commented on September 3, 2024 2

For anyone trying to get this working, this was the change I made to pass the icon from the app to the window:

//webview_edge.cpp

   browser_window(msg_cb_t cb, const char* title, int width, int height, bool resizable)
        : m_cb(cb)
    {
        HINSTANCE hInstance = GetModuleHandle(nullptr);

        HWND currentWindow = GetActiveWindow();

        // "1" is the default icon resource name used by winres 
        HICON parentIcon = (HICON)LoadImage(
            hInstance, 
            MAKEINTRESOURCE(1), 
            IMAGE_ICON, 
            0, 
            0,
            LR_DEFAULTSIZE
        );

        WNDCLASSEX wc;
        ZeroMemory(&wc, sizeof(WNDCLASSEX));
        wc.cbSize = sizeof(WNDCLASSEX);
        wc.hInstance = hInstance;
        wc.lpfnWndProc = WebviewWndProc;
        wc.lpszClassName = L"webview";
        wc.hIcon = parentIcon; // add the icon here
        RegisterClassEx(&wc);

This is my rust build script:

\\build.rs
use winres;

fn main() {
    let mut res = winres::WindowsResource::new();
    res.set_icon("Micro.ico");
    res.compile().unwrap();
}

I can't think of an easy way to locate the icon used by the taskbar (and so have had to refer to the icon resource by name).

One possibility would be to agree upon a default resource name to be used for the window icon (rather than just 1!). winres supports setting the resource id so this wouldn't cause issues for Rust users.

from web-view.