Git Product home page Git Product logo

Comments (5)

borisdj avatar borisdj commented on July 17, 2024

I agree, and will commit the change soon with proposed fix.

from efcore.bulkextensions.

Feoni4 avatar Feoni4 commented on July 17, 2024

And i'm interesting - why we can not use connection from context as SqlBulkCopy constructor parameter?
(SqlConnection)context.Database.GetDbConnection()

You are using almost the same approach in EFCore.BulkExtensions.TableInfo.CheckHasIdentity method.

I'v made a pull request for it: #10

from efcore.bulkextensions.

borisdj avatar borisdj commented on July 17, 2024

CheckHasIdentity was later added feature, but I did not refactor SqlBulkOperation at that time.
Meaning it can be used.
I have merged your request and made some more refactoring so pull the latest code repo.
SqlBulkCopy is now in using block so explicit Dispose is not required.
Once you confirm that everything is working for you I will close this issue.

from efcore.bulkextensions.

Feoni4 avatar Feoni4 commented on July 17, 2024

Everything is working fine now, issue can be closed
I think that using context connection also solve #4 and #9, but i have not tested it.

from efcore.bulkextensions.

borisdj avatar borisdj commented on July 17, 2024

I did tested it and it is not connected with this.
So Trusted_Connection=True; is still required in ConnectionString.
I have added this remark in README.

from efcore.bulkextensions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.