SDP v3.1 Github Enterprise on pull request issue about sdp-libraries HOT 11 CLOSED

@Wayonb we are going through some internal team adjustments. We will provide updates after resolving staffing issues

from sdp-libraries.

no worries, sorry for the late response

from sdp-libraries.

Hi, I am also hitting this issue with github.
Any update on when a fix will be release?

from sdp-libraries.

@tomhuang12 thanks. your first two corrections are probably correct. do you mind submitting a pull request?

from sdp-libraries.

@tomhuang12 my short review, the last problem may be the following: look at the example config: https://boozallen.github.io/sdp-docs/sdp-libraries/3/libraries/git.html.

libraries{
  git{
    github
    github_enterprise
    gitlab{
      connection (optional) = String // for gitlab_status
      job_name (optional) = String
      job_status (optional) =  "pending" or "running" or "canceled" or "failed" or "success".
    }
  }
}

from sdp-libraries.

@cokieffebah To fix the third problem, I remember reverting back just the git library to 2.5 version's.

I can submit the fix for the first two problems.

from sdp-libraries.

Also @tomhuang12 , look at https://github.com/boozallen/sdp-libraries/blob/3.1/libraries/git/steps/git_distributions.groovy#L71. Maybe output env.GIT_LIBRARY_DISTRUBITION to see its value. The code uses this value to pull the implementation (github|github_enterprise|gitlab). So line https://github.com/boozallen/sdp-libraries/blob/3.1/libraries/git/steps/on_pull_request.groovy#L14: def source_branch = git_distributions.fetch().get_source_branch(), functionally is: def source_branch = getStep(env.GIT_LIBRARY_DISTRUBITION).get_source_branch()

from sdp-libraries.

That could be it. I don't have access to the pipeline to test anymore :(

from sdp-libraries.

@cokieffebah In my environment GIT_LIBRARY_DISTRUBITION seem to be correct.

GIT_LIBRARY_DISTRUBITION=github

from sdp-libraries.

no new release cut/updated, but I believe the temporary fix has been approved and merged into main in #144.

from sdp-libraries.

This change is now in main

from sdp-libraries.