Comments (8)
fiesh
commented on May 19, 2024
10
With boost 1.67 and clang-7, I can reproduce the issue with this:
echo '#include <boost/log/utility/setup.hpp>' > /tmp/a.cpp && clang++ -c -march=haswell /tmp/a.cppIn file included from /tmp/a.cpp:1:
In file included from /usr/include/boost/log/utility/setup.hpp:20:
In file included from /usr/include/boost/log/utility/setup/common_attributes.hpp:22:
In file included from /usr/include/boost/log/attributes/counter.hpp:26:
In file included from /usr/include/boost/atomic/atomic.hpp:20:
In file included from /usr/include/boost/atomic/fences.hpp:21:
In file included from /usr/include/boost/atomic/detail/operations.hpp:17:
In file included from /usr/include/boost/atomic/detail/operations_lockfree.hpp:21:
In file included from /usr/include/boost/atomic/detail/ops_gcc_atomic.hpp:24:
/usr/include/boost/atomic/detail/ops_gcc_x86_dcas.hpp:408:16: error: address argument to atomic builtin cannot be const-qualified ('const volatile boost::atomics::detail::gcc_dcas_x86_64::storage_type *'
(aka 'const volatile unsigned __int128 *') invalid)
return __sync_val_compare_and_swap(&storage, value, value);
^ ~~~~~~~~
1 error generated.
from atomic.
timgivois
commented on May 19, 2024
6
So basically, this is fixed in 1.69 which is incompatible with MacOS and that means you won't fix 1.67....
from atomic.
fiesh
commented on May 19, 2024
1
6e14ca2 indeed fixes the issue -- boost 1.69 works! Thanks!
from atomic.
Lastique
commented on May 19, 2024
I can't reproduce this. What clang version do you use?
from atomic.
Lastique
commented on May 19, 2024
On 07/18/18 00:30, David Callahan wrote:
Using current trunk (master).
Here is a test case
|#define BOOST_ATOMIC_DETAIL_X86_HAS_CMPXCHG16B 1 #include
<boost/atomic.hpp> typedef boost::atomics::detail::gcc_dcas_x86_64<true>
DCAS; const volatile DCAS::storage_type data = 0; unsigned get() {
return DCAS::load(data, boost::memory_order::relaxed); } |
The current develop doesn't fail the compilation with clang 6.0, but the
test case is not valid. boost::atomic objects (and their internal
storage) must reside in writable memory. load() may issue store
operation on the storage memory even though the stored value doesn't change.
from atomic.
Lastique
commented on May 19, 2024
On 12/18/18 3:18 PM, fiesh wrote:
@Lastique Any chance this can be re-opened?
No, the problem has been fixed already.
from atomic.
fiesh
commented on May 19, 2024
On 12/18/18 3:18 PM, fiesh wrote: @Lastique Any chance this can be re-opened?
No, the problem has been fixed already.
Yeah that's why I had removed the comment before your answer and replaced it with the other one.
from atomic.
bilalebi
commented on May 19, 2024
I had the same issue but upgrading to boost 1.72 solved it.
I'm on Mac Catalina
from atomic.
Related Issues (20)
- Consider not using _mm_mfence even when it is available HOT 9
- Document that BOOST_ATOMIC_NO_CMPXCHG8B may be not useful for MSVC HOT 2
- atomic/detail/fence_arch_ops_gcc_arm.hpp:70:13: error: expected string literal in 'asm' HOT 1
- Cross compiling boost_1_56_0 compilation error in atomic lib HOT 3
- Boost atomics on aarch64 produce invalid instructions HOT 1
- Build failure on nios2 architecture HOT 7
- Consider removing the AARCH64 128 bit atomic implementation (LDXP+STXP loop) HOT 4
- File is missing: lock_pool_init1.ipp HOT 3
- Boost Log fails to build (MSVC, ARM64) HOT 1
- Since synchronization.lib is only added to usage-requirements... HOT 7
- _mm_set1_epi64x intrinsic workaround inaccurate for VS2015 HOT 1
- [question] risc-v support HOT 4
- UWP support HOT 3
- Boost Atomic 1.78 breaks macOS/iOS integration HOT 4
- Remove or fix relative includes HOT 1
- Documentation redirect link broken HOT 4
- Cross compilation issues on x86 to A64FX HOT 4
- Fails to build with `toolset=msvc-14.0 cxxstd=latest` HOT 1
- Cannot get boost::atomic_ref to compile using a const integer HOT 2
- is_lock_free() and is_always_lock_free not consistent. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from atomic.