Comments (9)
Any thoughts on this?
from spree_avatax_certified.
@kknd113 Benefits are limited to a primarily structural difference. But I thiunk it makes sense to follow the spree idioms. So we are working on it. @acreilly already has this in motion I believe......your thoughts are welcome @kknd113
from spree_avatax_certified.
@dhonig Correct me if I'm wrong but it seems like it's more than just a structural difference. For example, this gem is applying tax as order-level adjustments instead of lineItem-level adjustments, which spree stopped doing from Spree 2-2.
from spree_avatax_certified.
@kknd113 @ericsaupe We just completed the calculator for 2-4-stable, we will be working on 3-0-stable and 2-3-stable next.
from spree_avatax_certified.
👍
from spree_avatax_certified.
@acreilly great work. Let's prepare appropriate release documentation, release notes etc. Then please get one final review from @dpritchett and then lets release.
from spree_avatax_certified.
@dhonig Should we look at doing tagged and versioned releases? The fact that we're maintaining ~3 branches concurrently makes it harder for me to imagine how we'd number the releases. I ask because that's the first thing I think of when it comes to release notes - version numbers.
from spree_avatax_certified.
cc @mtomov
from spree_avatax_certified.
Closed via #47
Code review and comments are still welcome.
from spree_avatax_certified.
Related Issues (20)
- Spree 3-1-0 stable HOT 3
- Not adding tax at all? HOT 5
- Cannot install from branch 2-4-stable anymore HOT 3
- TypeError: superclass mismatch for class ReturnTax HOT 7
- spree 3.3 HOT 2
- Configurable timeouts? HOT 5
- Cannot install from branch master HOT 3
- Spree::Payment#avalara_finalize bug HOT 1
- Line items with adjustments get double-applied discount amounts, causes under-reporting of tax liability HOT 11
- Pre-tax values being set incorrectly outside of US and Canada HOT 4
- avalara_capture on promotion activate unnecessary? HOT 1
- 2-3-stable and 2-4-stable missing latest 3-0-stable niceties HOT 2
- 2-3-stable needs the calculator refactor merged in
- [2-3-stable] RMAs can be processed multiple times HOT 3
- Avalara Tax adjustment should always be in closed state. HOT 6
- uninitialized constant SpreeAvataxCertified::Seeder HOT 5
- display_avalara_tax_total from 2.3 stable to 2.4 stable HOT 2
- Avatax submitting as 'Uncommitted' HOT 1
- Are estimations supported? HOT 5
- Tax code is left out of return invoice call HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spree_avatax_certified.