Comments (5)
Thanks for reporting.
This is a though one, since I can't test if it's working again or not after doing a change.
What I will do is change the incrementUnitScores functions (because even if they are not related, they get in the way of debugging after all), then check more deeply the helpers readUnitsArray_Sub49EFA0 and initializeEmptyUnitsLinkedListRef_Sub49E4E0 for missing/wrong arguments, because they are the most likely cause.
from gptp-for-vs2008.
I'm making some changes, but I don't feel like they would really fix a thing.
I need to confirm something: when you say "I checked it both with infestation hook enabled and disabled", did you make your mod with just the infestation hook disabled and tested it like that, or did you just compare the modded/unmodded behavior of Starcraft?
The issue is that I suspected that something went wrong with readUnitsArray_Sub49EFA0, but everything I saw should be correct, BUT I realized that that function is actually hooked (in give_unit.cpp), so if you just tested modded behavior against unmodded behavior, there's a possibility that the issue would come from the give_unit hook instead.
I will check the whole infestation hook again, but I still think only readUnitsArray could make things go wrong, so I hope you will be able to answer.
edit: I actually found something wrong.The function orderReturnToIdle used at the end of orderMorphIntoInfested...should not exist at all in this hook!!It should be actUnitReturnToIdle used there.
In addition to the previous confirmation, maybe you can try changing the code to use the correct function, and see if that work, and report about it.
Thanks in advance.
from gptp-for-vs2008.
For "disabled" hook I just commented out infestation hook, the rest is the same. Thanks, I'll check it with new changes.
from gptp-for-vs2008.
I checked it now, everything works, AI now produces Infested Terrans from Infested Command Centers and other infested buildings (I made Barracks, Factories, Starports and Supply Depots infestable, and added new infested structures for them).
from gptp-for-vs2008.
Ok, thank you for your help.
Will consider it fixed in Version 4.025.
from gptp-for-vs2008.
Related Issues (20)
- Cheat hooks not possible
- Possible Issue with Unit_Train hook HOT 3
- Consume max energy comparison is incorrect HOT 1
- Some Issues HOT 1
- Optical Flare crashes the game when cast HOT 4
- Medic crashes the game when ordered to attack in a group HOT 2
- Create CGame struct HOT 1
- Hooks - Minor improvements HOT 2
- Canceling all units in carrier's queue crashes the game HOT 2
- Recharge Shields hook is non-functional HOT 1
- Defensive Matrix overlay persists after effect ends HOT 1
- Infestation hook cause crash HOT 2
- Update in progress, currently instable HOT 2
- Util hooks trouble with multiplayer HOT 2
- Stats panel display inject is missing HOT 2
- Cancelling research crashes the game when Cancel Research hook is enabled HOT 1
- Mistake in building_morph hook HOT 1
- Mistake in building_morph.cpp HOT 1
- This is the old version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gptp-for-vs2008.