Git Product home page Git Product logo

Comments (5)

mitechie avatar mitechie commented on May 29, 2024

Changed my mind on this. Implementing this as the start of the commands/read later support. Started implementing, but we start to want to import some of bookie-core so will need to refactor some of it to the popup specific vs the shared libary bits. Things like bookie.call need to be able to be imported in other places (this is kind of true of the main site as well)

Will work on saving a url as new bookmark with the !later tag. (shorter than toread and readlater)

from bookie.

mitechie avatar mitechie commented on May 29, 2024

Thinking that the best way to handle this, if the current page is something you've already bookmarked, is to catch this specific api call, and append the !later tag onto the existing. I don't want to pull the current info first, and I don't want to wipe existing tags/desc/data.

We could technically add/remove the item from the page based on if the page was bookmarked already or not (only displaying on pages that aren't bookmarked) but then there's this inconsistant ui things I'm not a fan of.

So the debate is should this be some sort of special "append" call to an update api, or should "toread" just be it's own api call that does a check on if the page is bookmarked or not.

We do want to treat this api call as a save command and respect the "cache content" config setting.

from bookie.

mitechie avatar mitechie commented on May 29, 2024

Right click context menu is now added in the chrome extension branch. It defaults to only adding a tag of !toread and auto uses the title as the description.

Right now it doesn't auto send the content along though, nor does it detect/deal with if the page is currently bookmarked. Since it happens in the background page, need to see how to better prevent you overwriting your existing bookmarks accidentally.

from bookie.

mitechie avatar mitechie commented on May 29, 2024

readlater will now send the content along if the cache_content setting is checked in the options.

The non-clobbering of the bookmark if it's already bookmarked will have to be done on the server side I think. I don't want to wait to load the current data from the server. So I'd prefer that if the only tag in the add command is a !readlater that we don't set that tag, and leave current tags on the bookmark.

from bookie.

mitechie avatar mitechie commented on May 29, 2024

This is started and rolling. Will create a new wishlist issue for better support for detecting if something is bookmarked/marked to read and for a right-click "mark read" option as well.

from bookie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.