Command-line flags about bookdown.bookdown HOT 11 CLOSED

/me nods

Given config file and option flag, which do you think should take precedence? (I'd say option flag.)

from bookdown.bookdown.

Definitely option flag; that's the most specific, as it's specified at time
of invocation.
On Jun 13, 2015 1:50 PM, "Paul M. Jones" [email protected] wrote:

/me nods

Given config file and option flag, which do you think should take
precedence? (I'd say option flag.)

—
Reply to this email directly or view it on GitHub
#11 (comment)
.

from bookdown.bookdown.

Agreed. Let me see what I can do. (Additionally, if you have time and inclination to work up a PR, I'll review it.)

from bookdown.bookdown.

This should be fixed; try the dev-develop branch and let me know how it goes for you.

from bookdown.bookdown.

Nope, not yet -- sorry for the noise.

from bookdown.bookdown.

@weierophinney OK, now try dev-develop. You should be able override with --template= and/or --target= at will.

from bookdown.bookdown.

I can confirm it works... but there's one oddity. :)

So, I have a directory structure that has the following:

documentation/
    doc/
        templates/
a-component/
    doc/
        bookdown.json
        book/

Inside of a-component/, I invoked bookdown with the following:

$ bookdown --template=../documentation/doc/templates/main.php doc/bookdown.json

This failed; it could not find the template:

Cannot find template 'doc/../documentation/doc/templates/main.php'.

In other words, it was resolving the relative path relative to the bookdown.json, not where bookdown was actually invoked.

I would expect it to resolve the path based on where the script was invoked. This would require resolving path arguments prior to parsing the bookdown.json, probably.

(When I re-ran and specified the path relative to the bookdown.json, it worked perfectly.)

from bookdown.bookdown.

Mmm, I can guess what the problem is. I'll take a look.

from bookdown.bookdown.

OK @weierophinney give it another go. The relevant commit is dee1f42 and takes away the code to "fix" the path to make it relative to the bookdown.json file.

from bookdown.bookdown.

Works perfectly, @pmjones ! 🚢 !!!

from bookdown.bookdown.

Finally. Sorry for the hassle, and thanks for your patience. New release forthcoming as a result!

from bookdown.bookdown.