Comments (8)
@zomars: Would this be for the backend one, the frontend one or both? (as in the general idea, not the specific twig code)
from translate.
My solution is for the frontend only, but maybe it could be implementing according to the number of the configured languages. Mine's just a quick fix.
from translate.
First, thanks for sharing your snippet. The way, I see it, the _localeswitcher.twig
, that is included with the extension, is just demonstrating how to implement such functionality. The template of the twif function can easily be overwritten. Also, the ul
from the default template can be styled with CSS, so it will look exactly like yours.
from translate.
In addition to what @madc said it is also planned to have proper language codes (as rel="alternate" and hreflang="lang-here") for each link in both the localeswitcher and to add them to <head>
(automatically that is), IIRC it helps search engines and accessibility to have a link that is "active"/"current" when doing that. Adding .localeswitcher .active {display: none;}
should remove that element from display while allowing you style the rest as needed, or want to you can remove it completely using a custom template.
If I'm wrong on the accessibility front (requiring a "current" link) I think we could probably remove it though.
And also thank you for raising the issue!
from translate.
One thing, that didn't leave my head since we talked about this other issue (#36):
It would make the localeswitcher way simpler, if we would move all this url business into the php code of the twig function and just inject a clean array of objects into the template.
So from the current template we should be able to have something like:
<ul class="localeswitcher {{ extraclasses }}">
{% for iso, locale in locales %}
<li {% if locale.active %}class="active"{% endif %}>
<a title="{{ locale.label }}" href="{{ locale.url }}">
{{ locale.label }}
</a>
{% endfor %}
</ul>
The object could look something like this:
[
en_GB: {
slug: en,
active: true,
label: English,
url: http://whatever/en
},
de_AT: {
slug: de,
label: German,
url: http://whatever/de
},
[...]
]
from translate.
@madc Yep, that's the plan... That part of the code is basically copy-pasted verbatim from the 2.2 version, so it hasn't gotten as much love as the rest. I also planned to make it available as a global in twig so that one could just loop and output it wherever without having to make a specific template for that part...
from translate.
That a good idea. I'd have a look at it, if you don't mid..
from translate.
Sounds great! Then we could get rid of the ugly getSlugFromLocale function too, which hasn't seen any work in a while either.
from translate.
Related Issues (20)
- Provide a short documentation about "how it works" HOT 1
- [BUG] Changelog is impossible to follow HOT 4
- Change the DB structure - use a table for translation HOT 2
- Arbitrary localized columns for searching
- translatable: true works but translatable: 1 not
- Redirecting homepage to subdomain HOT 1
- [BUG] No language switcher in contenttype when no tabs are present
- [RFC] Make language switcher on contenttype new pages configurable
- [RFC] Twig_Error_Runtime after updating to Translate 4.1.5 HOT 1
- Any page not preceded by '/contenttype' will switch website to default language HOT 1
- [RFC] Translate taxonomies HOT 2
- [BUG] saving with templatefields throws: Warning: Invalid argument supplied for foreach() HOT 1
- [BUG] status update deletes localized contents HOT 1
- Translations are not saved ? Missed a configuration ? HOT 9
- [RFC] Implementing a routing override blacklist
- Redirect ALL urls to default locale HOT 1
- [RFC] Remove /en slug from URL if default language is en_GB
- [BUG] Error when updating php7.2 -> php7.4 (but I found a trick) HOT 1
- [BUG] Composer error
- [BUG] repeater field is set to a row prior when there's no translation being set on the current row
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from translate.