Mount point in path about thumbs HOT 8 CLOSED

So creating a new controller would present a bunch of work, because of the caching aspect (thumbnails are saved to filesystem).

I think we could handle the change in the same controller there would just be some edge cases.
Say you had: files://files/foo/bar.jpg that being a files folder instead the files folder/filesystem. It would previously generate a route like this: /thumbs/5x5c/files/foo/bar.jpg. If that was used on the controller (with my change), it would be parsed as files://foo/bar.jpg, missing the inner files folder. As long as all cache is invalidated, including cache gateways, then the route would be regenerated like this: /thumbs/5x5c/files/files/foo/bar.jpg which would be parsed correctly.

I think this edge case is small enough that it probably won't be a problem. As long as cache is invalidated, so the thumb routes are regenerated correctly.

from thumbs.

We could also do another controller prefix.

More work, but wouldn't that be a clearer way forward?

from thumbs.

More work, but wouldn't that be a clearer way forward?

Probably. But it means duplicating the controller and we have a filesystem problem too. If saving thumbnails to disk is enabled then there are two folders...I guess that's not terrible though.

Definitely pays off in the long run not having to guess which filesystem to use.

from thumbs.

Could we have the old controller extend the new controller and call parent functions with a corrected path, or am I miss understanding the problem? (It's Monday after all)

from thumbs.

Works for me.

from thumbs.

K I'll work on PR at some point soon.

from thumbs.

Ok I lied I can't do it in same controller without breaking BC.

Everyone ok if I do a major version for this change?

from thumbs.

Modified approach approved at dev-meeting.

@CarsonF PR away 👍

from thumbs.