Git Product home page Git Product logo

Comments (4)

bogdan avatar bogdan commented on June 2, 2024

Can you show the grid source code?

from datagrid.

lukasedw avatar lukasedw commented on June 2, 2024

Sorry, it was my fault.

from datagrid.

bogdan avatar bogdan commented on June 2, 2024

I actually can reproduce this issue. The order is really ignored when using batches. It seems like this is a rails batches design that can not be turned off:

https://github.com/rails/rails/blob/311d0babfbacd105c2452339e9037e4a50400183/activerecord/lib/active_record/relation/batches.rb#L292

I think it is bad: Rails should allow a custom order when using batches. I don't see any way to override this behaviour on the datagrid level within rails (even with monkey patch/power hacking).

So, currently the only idea is submit a PR into rails that would allow to keep relation order.

from datagrid.

bogdan avatar bogdan commented on June 2, 2024

@zhuravel, I would want to know your opinion on the subject as I believe you are extensively using datagrid with batches in your project.

Rails basically ignores the relation order when using batches: https://github.com/rails/rails/blob/311d0babfbacd105c2452339e9037e4a50400183/activerecord/lib/active_record/relation/batches.rb#L292

Did you notice that behaviour? Does it cause issues for you? Do you have a workaround or best practice?

from datagrid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.