ZFS init fails on Centos due to not loaded module about puppet-zfs HOT 4 CLOSED

I've just pushed some changes to hopefully fix this. Basically I've re-added the ExecStartPre= lines back to the systemd units by way of some override files. I needed to do it this way as the Debian 10 package is a broken in much the same way and these need to be present before the package is installed for the first time.

I've also added EL8 support now that the EPEL module has been updated. If you're able to make use of a git checkout the changes are all in master, otherwise I'll cut a 2.2.8 release shortly.

from puppet-zfs.

It should always load the module, at least it always has done. The modprobe hack is there because the old SysV init scripts all check whether the module is loaded and bail out with an exit code of 0 which then just confuses Puppet as it thinks the service started successfully.

I'm fairly sure the Systemd unit files had a modprobe line in them, something like ExecStartPre=-/sbin/modprobe zfs which is basically doing the same thing. Perhaps that's been dropped in the latest versions, I'm away from my ZFS host so I can't check until later, maybe you can confirm if they still contain that?

I assume if you manually run modprobe zfs it does actually load the module?

from puppet-zfs.

Yes, they (ZOL) replaced the modprobe with another logic: in 0.8.3 openzfs/zfs@a6cc975#diff-fe9214b8af4a902509a60f7290d138a7 They say with that change a explicit modprobe is no longer needed, because calling the zfs binary will auto-load the module on first request. However this didnt work, at least on my system, maybe because no ZFS pool exists initially..

A manual modprobe zfs works fine, but this is a manual action which is needed after ZFS is installed, and should be ideally done by the zfs puppet module to avoid failed puppet runs and manual interaction.

Probably adding a explicit modprobe zfs also for RHEL7/8 systems wont hurt, would be great if you could consider adding this.

from puppet-zfs.

Thanks for the pointer to the commit, it does indeed look like they've removed all of the modprobe lines. I think it should still load properly even if you didn't have any ZFS pools created. I'm not sure why it's not loading automatically, but if it works after a reboot then something somewhere needs restarting, my hunch would be udev.

from puppet-zfs.