Git Product home page Git Product logo

Comments (11)

bobbingwide avatar bobbingwide commented on September 24, 2024

The code should work with Gutenberg v.4.1.0 when it's released. Currently v4.1.0-rc.2

from oik-blocks.

bobbingwide avatar bobbingwide commented on September 24, 2024

It would be nice if the JavaScript ( .js ) code was documented according to WordPress's JavaScript Documentation Standards. https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/

e.g. For the start of each file

/**
 * Summary. 
 *
 * Description.
 *
 * @copyright (C) Copyright Bobbing Wide 2018
 * @author @bobbingwide
 */

Not sure if it's necessary to use @url, @link or others. What about @Package?

from oik-blocks.

bobbingwide avatar bobbingwide commented on September 24, 2024

oik-block is not working at all on WordPress 5.0-beta5 on my new laptop with Edge.
Could be due to a problem with oik-bwtrace… which is not installed.

<b>Warning</b>:  require_once(C:/apache/htdocs/wordpress/wp-content/plugins/oik-bwtrace/includes/bwtrace-actions.php): 
failed to open stream: No such file or directory in 
<b>C:\apache\htdocs\wordpress\wp-content\plugins\oik\libs\oik_boot.php</b> on line <b>70</b><br />

It was. Workaround was to install oik-bwtrace. It didn't need activating.

from oik-blocks.

bobbingwide avatar bobbingwide commented on September 24, 2024

With WordPress 5.0-beta5 but NOT Gutenberg the Github Issue block produces a Console log message and none of the oik-block blocks load.

Uncaught TypeError: Cannot read property 'TextControl' of undefined
    at eval (index.js?7662:25)
    at Object.<anonymous> (editor.blocks.js?ver=1542566507:595)
    at __webpack_require__ (editor.blocks.js?ver=1542566507:20)
    at eval (index.js?8193:1)
    at Object.<anonymous> (editor.blocks.js?ver=1542566507:588)
    at __webpack_require__ (editor.blocks.js?ver=1542566507:20)
    at editor.blocks.js?ver=1542566507:63
    at editor.blocks.js?ver=1542566507:66

I mentioned this on Slack and was told I needed to add dependencies on the script registration. I needed to add wp.components and wp.editor to make it work in native WordPress 5.0-beta5.
wp-editor needed for Editable used by the Person block.

from oik-blocks.

bobbingwide avatar bobbingwide commented on September 24, 2024

It turns out that the real problem was that my code was registering the editor blocks on the front end. This also caused a problem with Autoptimize. The fix is applied in https://github.com/bobbingwide/oik-blocks

from oik-blocks.

bobbingwide avatar bobbingwide commented on September 24, 2024

When responding to enqueue_block_editor_assets the code currently checks if we’re doing_filter( ‘editor_replace’ ). This test only works when Gutenberg is activated. The need for the test, to avoid enqueuing the blocks when loading the Classic editor, is no longer necessary. So the test should be removed.

from oik-blocks.

bobbingwide avatar bobbingwide commented on September 24, 2024

I noticed a major problem when WordPress SEO was activated.
Autosave never seemed to finish.
In the console log there was a 500 response occurring.
This was due to logic in oik_blocks_editor_scripts() that was testing if the Classic Editor was being loaded. It seems that in conversion from Gutenberg to 5.0 the enqueue_block_editor_assets action is called for requests to display the WordPress SEO metabox.

/wp-admin/post.php?meta_box=1&action=edit&classic-editor&post=31818

The logic should not fail in this instance. Either we update the check or simply remove the ( debugging ) call to the missing function gob().

from oik-blocks.

bobbingwide avatar bobbingwide commented on September 24, 2024

Gutenberg 4.8.0 was released on 7th/8th Jan 2019. WordPress 5.0.3 on 9th Jan.

from oik-blocks.

bobbingwide avatar bobbingwide commented on September 24, 2024

It's about time we switched from alpha versions to proper semantic numbering. The next version, delivering the Block info block will be 0.2.0.
This version won't be on WordPress.org since there are still many blocks that Need work.

from oik-blocks.

bobbingwide avatar bobbingwide commented on September 24, 2024

The table should be updated to reflect the status for all the blocks under development for oik-blocks and their operational status with Gutenberg 5.1.1 and WordPress 5.1

from oik-blocks.

bobbingwide avatar bobbingwide commented on September 24, 2024

Closing this as I'm now retesting the most recent version of the blocks with WordPress 5.9 and/or Gutenberg 12.3.2

from oik-blocks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.