Git Product home page Git Product logo

Comments (3)

bobbingwide avatar bobbingwide commented on June 25, 2024

Another form that doesn't work, and doesn't even produce a message, is when there's no space between the block name ( template-part ) and the left curly brace, or when the wrong character has been used. eg (.

<!-- wp:template-part{"slug":"footer-menu","theme":"fizzie" "className":"footer-menu"} /-->
<!-- wp:template-part ("slug":"footer-menu", "theme":"fizzie" "className":"footer-menu"} /-->

from fizzie.

bobbingwide avatar bobbingwide commented on June 25, 2024

There are many more ways to write an invalid block tag inside an HTML comment.
I've found a few more recently while developing SB.

Too many closing curly braces.

<!-- wp:template-part {"slug":"page-footer","theme":"sb","layout":{"inherit":true}},"tagName":"footer"} /-->

I had this problem with a template-part. The extra curly brace prevented any of the attributes being set.
This caused a Warning messag from template-part.php

Warning: Undefined array key "slug" in C:\apache\htdocs\wordpress\wp-content\themes\sb\includes\template-part.php on line 78

An end block slash where it shouldn't be

<!-- wp:query-loop {"className": "sb hero" } /-->

This one took me longer to find. See bobbingwide/sb#13

from fizzie.

bobbingwide avatar bobbingwide commented on June 25, 2024

I'm closing this as wontfix. Some of the badly formed template-part tags will be removed from the templates that used them. This should improve performance very slighty and may also help anyone reading the code.

from fizzie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.