Comments (4)
villfa
commented on June 2, 2024
1
Thank you for the report!
The right key is commitsSince.
This regression exists since 1.6.0 and has been introduced by 1b59a42.
In my opinion we should support the 2 spellings just in case some users already use the singular form.
However the usage of commitSince must trigger a deprecation message indicating it won't be supported in the next major version.
from churn-php.
MGatner
commented on June 2, 2024
It is because the configuration string is actual the singular commitSince:
The Validator is actually the plural though as well. Need a maintainer to advise, then I can send a PR one way or another.
from churn-php.
villfa
commented on June 2, 2024
FYI the fix has been released with Churn 1.7.1 :)
from churn-php.
MGatner
commented on June 2, 2024
🥳🎉🎊
from churn-php.
Related Issues (20)
- directoriesToScan configuration doesn't handle relative paths well
- Warn when a configuration key is unknown
- [Regression] Too long paths HOT 3
- Add PHPCompatibility to the CI
- Add mutation testing
- Add PHPStan
- Make run the default command
- Fallback on churn.yml.dist
- Add a manifest to the phar
- Test phar with PHP 7.0
- Use composer-runtime-api v2
- Deprecated: Return type of RequirementCollection::getIterator() HOT 3
- [1.6.0] Manifest typo error HOT 4
- Configure `git` path command HOT 2
- Feature: Allow to use cognitive instead of cyclomatic complexity HOT 2
- Support markdown format
- Fix PSR violations
- Negative Scores? HOT 3
- Only displays 5 files instead of 10 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from churn-php.