Git Product home page Git Product logo

Comments (6)

wvangeit avatar wvangeit commented on August 21, 2024

At the moment this feature is implemented as the difference between the time of the peak and the start of the spike (using the respective features to calculate these):

aprisetime[i] = t[peakindices[i]] - t[apbeginindices[i]]

With the 10-90% do you mean the voltage is at 10-90% of the AP amplitude?

from efel.

alexyonk avatar alexyonk commented on August 21, 2024

For example, say that the AP_begin_voltage occurs at 0mV and the peak_voltage is 100mV. Instead of calculating the full rise time (0 - 100), is there a way to calculate the time it takes to rise from 10% to 90% of the voltage?

from efel.

wvangeit avatar wvangeit commented on August 21, 2024

Unfortunately I don't think we have a feature that can be used for that. It could be implemented, I only wonder how we should parametrize it. I assume we don't want to fix the 10%-90% levels

from efel.

alexyonk avatar alexyonk commented on August 21, 2024

I would agree with the last statement. According to a more experienced colleague, the calculations relating to rise time are variable (10-90%, 20-80%, etc.). Would it be possible to include both rise_begin_perc and rise_end_perc as global settings that can be modified by the user similar to interp_step and voltage_base_start_perc?

from efel.

wvangeit avatar wvangeit commented on August 21, 2024

@AurelienJaquier or @anilbey Could you have a look at adding this to the feature? The default should be the old behavior. Thanks.

from efel.

AurelienJaquier avatar AurelienJaquier commented on August 21, 2024

This issue should have been solved with PR #198

from efel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.