Git Product home page Git Product logo

Comments (4)

esc avatar esc commented on June 25, 2024

I think this is a reasonable choice. Need to make sure though, that the version, versionlz, and compcode are clearly documented. Those variables are quite similar so we should seek to avoid confusion.

  • version is the format version of the Blosc metaccodec itself
  • compcode is the code for the real/internal/implementation codec library ( NOT the codec implementation, but see #45) used.
  • versionlz is the format version of the real/internal/implementation codec used.

Not sure yet about the correct terminology to use to describe the real/internal/implementation codec.

from c-blosc.

FrancescAlted avatar FrancescAlted commented on June 25, 2024

Hmm, after putting some serious thought on this, I am leaning now to add a new API call:

int blosc_cbuffer_compcode(const void *cbuffer);

Where it returns the compressor code for the buffer. That avoids the API change, and although it makes the API a bit larger, I think it is nice to be explicit. Also, when in the future several filters would be allowed, a new API call could be added too:

int blosc_cbuffer_filtercode(const void *cbuffer);

What do you think?

Also, I agree that current variables in blosc_cbuffer_versions() must be better documented.

from c-blosc.

esc avatar esc commented on June 25, 2024

I think it would fit nicely with the function for setting the complib, some good symetry. Also, the cost of avoiding the API change in this case is not very large so it is preferable.

from c-blosc.

FrancescAlted avatar FrancescAlted commented on June 25, 2024

Fixed in rev 365f819. I finally decided to go with a blosc_cbuffer_complib() because the most you can do is guessing the compression library, and not the actual compressor used. This only actually applies to LZ4, where both lz4 and lz4hc compressors map to the LZ4 library, but in the future there could be similar cases for other libraries.

from c-blosc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.