Comments (4)
I think this is a reasonable choice. Need to make sure though, that the version
, versionlz
, and compcode
are clearly documented. Those variables are quite similar so we should seek to avoid confusion.
version
is the format version of the Blosc metaccodec itselfcompcode
is the code for the real/internal/implementation codec library ( NOT the codec implementation, but see #45) used.versionlz
is the format version of the real/internal/implementation codec used.
Not sure yet about the correct terminology to use to describe the real/internal/implementation codec.
from c-blosc.
Hmm, after putting some serious thought on this, I am leaning now to add a new API call:
int blosc_cbuffer_compcode(const void *cbuffer);
Where it returns the compressor code for the buffer. That avoids the API change, and although it makes the API a bit larger, I think it is nice to be explicit. Also, when in the future several filters would be allowed, a new API call could be added too:
int blosc_cbuffer_filtercode(const void *cbuffer);
What do you think?
Also, I agree that current variables in blosc_cbuffer_versions()
must be better documented.
from c-blosc.
I think it would fit nicely with the function for setting the complib, some good symetry. Also, the cost of avoiding the API change in this case is not very large so it is preferable.
from c-blosc.
Fixed in rev 365f819. I finally decided to go with a blosc_cbuffer_complib()
because the most you can do is guessing the compression library, and not the actual compressor used. This only actually applies to LZ4, where both lz4
and lz4hc
compressors map to the LZ4
library, but in the future there could be similar cases for other libraries.
from c-blosc.
Related Issues (20)
- funtions blosc_set_compressor & blosc_get_compressor
- Unable to build on macOS with Apple Clang 12 HOT 6
- build for arm64 error HOT 2
- c-blosc needs a CMake package file HOT 3
- Is there a function like compress_bound() ? HOT 1
- Files referencing non existing `LICENSE.txt`
- Conda package wants unprovided compression functions HOT 2
- Update conda package of latest release 1.21.1? HOT 3
- Support Quantile Compression codec HOT 3
- Linker error
- macOS: Universal2 build fails on SSE2 HOT 4
- Switching from `master` to `main` HOT 1
- Uncompressable data set? HOT 6
- THOUGHTS_FOR_2.0.txt
- 1.21.1: test suite is failing HOT 6
- zlib / zlib-ng licence file HOT 2
- CMake: Enable external ZLIB from CMake variable ZLIB_ROOT
- Upgrade ZSTD to 1.5.5 due to potential corruption HOT 4
- Illegal Instruction vinserti128 in set_host_implementation HOT 11
- Troubles while building HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from c-blosc.