Support for google.rpc.Status about bloomrpc HOT 6 CLOSED

@fenos , thanks for a swift reply!

The file is included by default in the grpc stack. The link I posted was to the original; this one tells the full story: https://github.com/grpc/grpc/tree/master/src/proto/grpc/status

from bloomrpc.

@seime Thank you for the link and for reporting this.

I believe that adding this specific type to the client will make the experience better.
So i'll be including it in the next minor release

from bloomrpc.

https://github.com/googleapis/googleapis/tree/master/google/rpc

from bloomrpc.

Hi @seime,

This protofiles are very specific to googleapis and not as generic as the well-known types such as:

• google.protobuf.Empty
• google.protobuf.Timestamp
• google.protobuf.Any
• more...

everything under google/protobuf/* is supported out of the box.

If you are on version 1.2.0 of bloomrpc you can use import paths feature where you can provide a local path where those protofiles can be found.

Keep in mind that the path needs to be absolute to your file system but the import will be then relative to that path.

Let me know what are your reasons to have google/rpc baked in bloomrpc.

from bloomrpc.

Unfortunately, I have to re-open this issue, as the current implementation which has been merged doesn't work when the app compiles, it just work on development mode 🤕

The reason is that it tries to look for the imported protofile in the filesystem but the app is packaged up and not able to locate it.

This is a "bug" or "limitation" of protobuf.js.

I've opened an issue in protobuf.js repo here protobufjs/protobuf.js#1157
to allow me to proper implement this feature.

The fix will follow along once i know more 😄

from bloomrpc.

This is now fixed by #55

from bloomrpc.