Git Product home page Git Product logo

Comments (4)

yeenow123 avatar yeenow123 commented on June 16, 2024 1

I see, I'm primarily using grpc-java, so dots in the package name are quite common :).

After removing the package name, it seems to load proto now. However, when going into my "put" endpoint I see the following.

{
  "error": "Error parsing the request message, please report the problem sharing the offending protofile"
}

This is with the following modified proto

syntax = "proto3";

import "google/api/annotations.proto";

package comsomeprofile;

service UserDataApi {
    rpc get(ReadRequest) returns (ReadResponse) {
        option (google.api.http) = {
        get: "/v1/read"
      };
    }

    rpc put(WriteRequest) returns (WriteResponse) {
        option (google.api.http) = {
        put: "/v1/write"
        body: "*"
      };
    }
}

message ReadRequest {
    repeated string userIds = 1;
    repeated string fields = 2;
}

message ReadResponse {
    map<string, InternalData> internalData = 1;
    map<string, ThirdPartyData>  thirdPartyData = 2;
}

message WriteRequest {
    map<string, InternalData> internalData = 1;
    map<string, ThirdPartyData> thirdPartyData = 2;
    int64 ttl = 3;
}

message WriteResponse {
    string userId = 1;
    bool status = 2;
}

message InternalData {
    map<string, string> data = 1;
}

message ThirdPartyData {
    map<string, Segments> data = 1;

    message Segments {
        repeated string segments = 1;
    }
}

Let me know if I should open this up another issue for this.

from bloomrpc.

fenos avatar fenos commented on June 16, 2024 1

@yeenow123 👆 It will fix both of your issues! I'm preparing the release

from bloomrpc.

fenos avatar fenos commented on June 16, 2024

Hi,

This is an interesting one, I think it's an edge case not covered in the editor.

From the first look at the protofile, I'm guessing that the offending line is the package name having a dot in the name.

Try to remove the dot from the package and try to import it again.

Thanks for reporting this, i'll be fixing this asap

from bloomrpc.

fenos avatar fenos commented on June 16, 2024

I think those are 2 slightly different problems, they will be both fixed.

Thanks for sharing this, it helps a lot to fix the parsing issue.

As I mentioned there is some issue parsing this specific protofile, I probably guess that I forgot to cover the map data type. I'll be confirming this once I see the stack trace.

Apologize for the inconvenient, I'll be trying to push a fix this evening!

from bloomrpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.