Comments (4)
ebatz
commented on September 16, 2024
Could you take a look at ebatz@31116cd and let me know what you think?
Passing around raw pointers, because handle_event() shouldn't modify or store the task object passed in anyway, and it's certainly guaranteed to continue to live while events are being handled.
from transwarp.
bloomen
commented on September 16, 2024
Cool, I just left the comments I had. Otherwise looks good!
from transwarp.
ebatz
commented on September 16, 2024
Thanks for the comments! (ebatz@8b7a5b4)
I have done the same for the executor, and if you're happy I think we're good to go here. (ebatz@5319426)
from transwarp.
bloomen
commented on September 16, 2024
Just a small thing I commented on in the tests, otherwise good to go!
from transwarp.
Related Issues (20)
- Fix appveyor build for C++17
- Schedule the same graph again HOT 1
- Control lifetime of task results HOT 11
- Merge `node` into `itask` HOT 3
- Measure unit test coverage
- Set up clang-tidy
- Add support for C++11 on master branch HOT 1
- Add transwarp to conan repo
- Add transwarp to vcpkg repo HOT 2
- Problem compiling wait_any task HOT 1
- std::result_of removed in C++20 HOT 1
- Transwarp doesn't seem to be fully move aware HOT 3
- if graph final have many leaf tasks, can transwatp get the final result? HOT 4
- Project doesn't install anything HOT 1
- Tasks are not executed HOT 5
- store parallel executor as a member variable causing crash HOT 2
- readability and interface HOT 1
- next() method documented but does not exist HOT 2
- How to handle sub task HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from transwarp.