Git Product home page Git Product logo

Comments (9)

blakeblackshear avatar blakeblackshear commented on May 20, 2024 1

I do have min person area defined for all regions on my cameras. And yes, if it wasn't defined, it would skip the continue and add all detected person objects.

from frigate.

aav7fl avatar aav7fl commented on May 20, 2024

Taking a look, I think this section is flipped. I think it's behaving more like a max_person_area since it's skips adding the person to the object if region cutoff value is larger than the actual value.

frigate/frigate/video.py

Lines 253 to 256 in 3019b02

# if the min person area is larger than the
# detected person, don't add it to detected objects
if region and region['min_person_area'] > person_area:
continue

If we wanted it to behave like a min_person_area, I would think that it would look more like:

# if the detected person area is larger than the
# min_person_area, don't add it to detected objects
if region and person_area > region['min_person_area']:
    continue

Maybe I'm mistaking the meaning of min_person_area?

from frigate.

blakeblackshear avatar blakeblackshear commented on May 20, 2024

Looked again, and I still don't think that is the issue. If the minimum area for that region is larger than the detected person's bounding box, the continue statement tells it to skip that object and move on to the next one. That is exactly what we want. Also, if this was flipped, I wouldn't get any detection on my cameras. I do agree that the person in your image seems too small for that threshold. Are you sure the right config file is being used?

from frigate.

aav7fl avatar aav7fl commented on May 20, 2024

I'm using the config a the top of the post with redacted credentials. I can see the white bounding region boxes in my mjpeg debug view, so I know it's reading the config.

I'm not super familiar with Python, but If min_person_area wasn't included, wouldn't it just evaluate false/not existing? Then it would skip the continue line and add the object.

So I'm wondering if your config contains min_person_area.

from frigate.

aav7fl avatar aav7fl commented on May 20, 2024

Thanks. I'm following now.

I'll see if I can step through it some more to resolve it.

from frigate.

blakeblackshear avatar blakeblackshear commented on May 20, 2024

What version are you running?

from frigate.

aav7fl avatar aav7fl commented on May 20, 2024

latest tag on docker hub. https://hub.docker.com/r/blakeblackshear/frigate

It looks like there are tags after that though.

from frigate.

aav7fl avatar aav7fl commented on May 20, 2024

I added a label to show the person size from the master repo. It looks like the sizes are way higher than I thought. I wanted to filter on 3000, but it looks like what I really want to filter on is 30000 (or maybe 300000?). Since a closeup of me near the camera clocked in at 500000 on my 1920x1080 image.

from frigate.

aav7fl avatar aav7fl commented on May 20, 2024

I'm closing this. After getting the viewbox with the area size figured it, it was definitely the case that they were way larger than I thought.

Merge this PR if you'd like them added. #47

from frigate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.