Git Product home page Git Product logo

Comments (8)

wojas007 avatar wojas007 commented on August 19, 2024 1

Well I opened the file that was in the folder you mentioned and replaced the warrior's icon myself xD

from skada-wotlk.

bkader avatar bkader commented on August 19, 2024

Hello again @wojas007 !
For Val'anyr, there are 2 spells or buffs, the valnyar one and the blessing of forgotten kings, the first one doesn't absorb at all unless the owner of the mace heals the target. So even if you have the proc and you don't heal it won't absorb unless you heal, for example if you apply Renew, everytime it ticks it proc's the Blessing of... which is the shield that absorbs. So if they have Val'anyr and it proc's, you should only see the blessing and not the mace buff (I mean that looks like the mace).

As for the red icons instead of role/class/spec, I noticed this when there is a delay in catching the combatlog data, other than that it should almost never occur. At least so far I didn't see it.
The spec icons are copied from talents, unless I made a mistake of course or specs had to be tweaked because some icons are similar. The are stored in the media\textures\icon-specs.tga file.

from skada-wotlk.

wojas007 avatar wojas007 commented on August 19, 2024

About Val'anyr:
Don't worry - I know how it works, but I just wanted to see the numbers, so we can potentially close the other issue.

About red squares:
Relogging or reloading does not help - only time fixes it.
BUT as I said threat module keeps showing red squares even if other modules show proper icons. I'll try to record this and maybe it will help. Unless you have an idea what could cause this.

About icons themselves:
I only thought that warrior fury could use other icon : p Like titan's grip talent one.

from skada-wotlk.

wojas007 avatar wojas007 commented on August 19, 2024

something like this
icon-specs.zip

And where are ROLE icons stored? Because there are 3 possible options: class, spec and ROLE.

from skada-wotlk.

bkader avatar bkader commented on August 19, 2024

Where did you get this pack from? You can use it of course, replace the old file and reload, it'll work just fine ๐Ÿ‘

from skada-wotlk.

bkader avatar bkader commented on August 19, 2024

And where are ROLE icons stored? Because there are 3 possible options: class, spec and ROLE.

The roles aren't stored anywhere. Interface\LFGFrame\UI-LFG-ICON-PORTRAITROLES, so basically the Tank, Healer and DPS icons you see on LFG.

from skada-wotlk.

wojas007 avatar wojas007 commented on August 19, 2024

Ok so if I understand you correctly, then they will only show in dungeons, right?

Btw if you liked that file I uploaded above (spec icons), you can use it of course.

I'll test modules more and maybe if I find it annoying I'll reopen. For now - closing this.

from skada-wotlk.

bkader avatar bkader commented on August 19, 2024

After few tests, I noticed the red icon. It is due to the default UnitGroupRolesAssigned function that returns sometimes unknown role, so I added Skada:UnitGroupRolesAssigned. I hope it will work better this way.

from skada-wotlk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.