Comments (5)
Well, if you really want to remove that function, the easiest and fasted way to do it is by simply emptying the content of that function, making it look like:
function Skada:MemoryCheck() end
Or if you give me time, I will add an option to enable/disable memory check.
from skada-wotlk.
@MaelKoT you can update the addon now, you will see this option added instead of modifying the files.
Whenever you have the chance to check if the fps drop is gone let me know please so I can close this issue. For now we will leave it open.
from skada-wotlk.
It has been already a 7 days, I presume that you didn't have any FPS drop or you didn't have the chance to test it. In either cases, I am closing this issue for now. Thanks a lot for your feedback.
from skada-wotlk.
Thanks for reporting this, it is fixed now. It should be Skada:Print
instead of self:Print
.
As for the MemoryCheck
function, it is only called out of combat and only in 2 situations:
- 3 seconds after the log (PLAYER_ENTERING_WORLD).
- 3 seconds after the combat ends.
I don't know if it was this specific lua error that was causing your FPS drop or the function itself or even something else, but try the fix and let me know.
THanks again.
from skada-wotlk.
Thanks, now I know when this function is called.
It's just that I specially set in the settings to save a large number of fights (~ 30-40), so that I can view them later, and not accidentally lose anything. I understand, this will take more memory and I don't want to see a warning 3 seconds after each fight ends. Is there anything I can do about this?
And yes - maybe Im wrong, and the FPS falls after battle, not during, now Im not sure about this anymore...
from skada-wotlk.
Related Issues (20)
- Total DPS or Damage isn't showing HOT 1
- Resets logs after death HOT 5
- Left click on Notifications to report an error
- Digital display automatic differs from western display HOT 6
- attempt to index global 'InterfaceOptionsFrame' (a nil value) HOT 1
- Lua error when moving window HOT 3
- Integration in GTFO addon error HOT 1
- KPack a few small questions HOT 2
- Even if you are in combat addon won't record any data HOT 1
- Tbc 2.4.3 version HOT 2
- Can't embed Skada into ELVUI panel. HOT 1
- "Total" segment showing only oveall data HOT 2
- Problem wheel speed
- Segment child window mode doesnt work HOT 1
- error in Mode child window mode HOT 1
- Resourсes and Rdruid talent HOT 1
- Return to character selection error HOT 6
- Ascension - CoA class icons broken HOT 1
- Skada ToolTipbar doesn't work...? HOT 2
- Missing entry for 'GTFO Alerts' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skada-wotlk.