Issue with Balancing Reactions (from examples) about chempy HOT 3 OPEN

from chempy.

So it looks like this is a bug in how the coefficients by which the equations should be multiplied are calculated. The code was using the result of sympy.primefactors() and division to get the coefficients instead of counting the factors from sympy.factorint(). The old code worked for non-repeating, relatively prime factors but was failing on others and the only test was on the former. I've managed to patch that and rework the elimination tests and add your examples. I've pushed the changes here. If you can test it, let me know how it works.

The sign of the coefficients still needs some work I believe. Everything works, signs included, except the manganese-bromate redox reaction. Right now the elimination coefficients are both negative and it seems like they should be positive but I need to chase more of the stoichiometry logic in other functions to be certain. I would also like to add some documentation on the signs of these coefficients (at least in the code; it may be elsewhere) and some more tests cases.

from chempy.

I've pushed the latest fixes to the above branch. The permanganate-bromate reaction elimination coefficients should both be positive but were both returning negative. The important thing was that both coefficients have the same sign; the negative would only reverse the reaction. This was happening arbitrarily based on whether the first reaction was eliminating a reactant and the second a product, or vice-versa. I've added a check for all negative coefficients, and that seems to solve all the current tests.

At this point, we should probably add more tests to increase confidence in the solution and get some more eyes on the changes. Currently, the elimination method will only handle two reactions and not any number of reactions in general. So it works fine for redox half reactions but would need to be generalized further before using for something like elimination in a sequence of Hess's Law reaction steps. There's a commented example of a failing test that demonstrates the problem.

from chempy.