Comments (4)
Also interested in that.
from bloom.
Changing the hash function would break existing filters.
If you believe that xxHash would be preferable, please prepare some benchmarks.
I am going to close this issue, please reopen with hard numbers so we can move the discussion forward.
from bloom.
I was looking to use the library to write parquet bloom filters and they only support xxhash https://github.com/apache/parquet-mr/blob/5608695f5777de1eb0899d9075ec9411cfdf31d3/parquet-column/src/main/java/org/apache/parquet/column/values/bloomfilter/BloomFilter.java#L32-L46. Would it be an option to make the hash function replaceable so users can provide a custom one?
from bloom.
We can accommodate a new variant, say xxbloom, within the same code base. I do not want to change the default as it would break existing code.
Dynamically assigned hash functions might be hard. First you’d need to make sure it does not harm performance… e.g., by reducing inlining. Second, you’d need to carefully define the interface and the requirements. Third, we want to preserve full backward compatibility.
So the best thing is a new variant…
Pull request invited!
from bloom.
Related Issues (20)
- Applying the bloom filter for HASH160 addresses HOT 11
- Looking for new maintainer HOT 5
- Issue when importing package from master branch HOT 4
- go.sum missing HOT 1
- Missing /v3 suffix in tagged revision HOT 1
- Question for hashing strings and order inside it HOT 3
- Backward compatibillity break test failures on s390x HOT 3
- Add TestOrAdd, TestOrAddString HOT 1
- The VERSION file is correct? HOT 1
- Error in readme.md of v3 HOT 1
- Max number of elements HOT 2
- module declares its path as github.com/bits-and-blooms/bitset but require github.com/willf/bitset HOT 1
- Create SECURITY.md HOT 2
- 2x 128 bit hash instead of 2x 64 bit hash. Why? HOT 1
- OOB read using ReadFrom HOT 5
- how much memory is used per item / false positive percentage?
- bits-and-blooms can ensure thread-safe/go-routine safe? HOT 1
- is there a way to save results to disk when reboot? HOT 1
- Dead link in README file
- Strange false positive with single item capacity filter
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bloom.