Comments (5)
This is true, but there are potential problems with upgrades. That's why the sql thread should be refactored first and added tests. These are the PRs that tried that but they are too big and need cleaning up: #1794 #1999 #2150
from pybitmessage.
The type of values whose declared type is blob:
- inbox.msgid : text
- inbox.sighash : text
- inventory.hash : blob
- inventory.payload : blob
- inventory.tag : blob
- objectprocessorqueue.data : (empty)
- pubkeys.transmitdata : text
- sent.msgid : text
- sent.toripe : text
- sent.ackdata : text
- settings.key : text
- settings.value : text, integer
from pybitmessage.
It actually isn't consistent across versions, there may be older databases which are different. That's why we need tests for this, even more for the data type change.
from pybitmessage.
How about this:
- Change all code at once to store all blob data as blob by using sqlite3.Binary(). Then,
- Search any blob data:
- First, try SELECT by blob keys using sqlite3.Binary(key).
- When there is no match found, as a fallback, try SELECT by text key using CAST(? AS TEXT) in SQLite sintax.
I think this should be compatible to any past versions and future updates, including migrations to Python3.
from pybitmessage.
I have implemented a quick workaround: #2248
from pybitmessage.
Related Issues (20)
- Append `*.sql` files into `buildozer.spec`
- APPImage doesn't connect anymore HOT 8
- Bitmesage Plus enhanced security
- Pyelliptic is deprecated HOT 1
- Arch Linux is missing a maintainer
- Linux Mint 21 (cinnamon) incompatibility
- Incorrect stream offset in `HandleDisseminatePreEncryptedMsg`
- *
- Peter Surda (Peter Šurda) poses a significant threat to Bitmessage. HOT 3
- PyQt4 module is not availabale anymore HOT 3
- Newbie on Linux(Ubuntu) with AppImage HOT 1
- Appimage release
- 中文比特channel (ad, can close me)
- How to setup the development environment which is identical to the one core developers are using? HOT 14
- How about using the "Black" code formatter on the whole codebase?
- Don't use "hello %1".arg("world") : arg() can't be used in Python 3 HOT 6
- objectracker.py should be renamed to objecttracker.py
- Texts of the peers are almost invisible on Dark theme of GTK HOT 1
- OpenBSD connectivity issues HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pybitmessage.