Changes of go ethereum from v1.8.13 to 1.8.15 about bitconch-core HOT 1 CLOSED

Changes of Ethereum 1.8.15:

miner: track uncles more aggressively
Purpose: ensures that the headers from the potential uncle list are only removed if the chain progresses beyond the 7 uncle depth.
changed files:
miner/worker.go
miner/worker_test.go

shh: fix loop in expire()
Chagned files:
whisper/whisperv5/whisper.go
whisper/whisperv5/whisper_test.go
whisper/whisperv6/whisper.go
whisper/whisperv6/whisper_test.go

cmd/swarm: disable ACT tests on windows
This PR disables ACT tests on Windows as they are consistently failing with: No connection could be made because the target machine actively refused it.
Until we fix this, these should not run on Windows, as AppVeyor is used to build artefacts during release.
Changed files:
cmd/swarm/access_test.go

cmd, core, eth, miner, params: configurable gas floor and ceil
Comments: adds --miner.gaslimit to the previous --miner.gastarget to also Purpose: support capping the gas to a certain threshold. The defaults for both floor and ceiling have been set to 8M according to mainnet rules.
Changed files:
cmd/geth/main.go
cmd/geth/usage.go
cmd/puppeth/module_node.go
cmd/puppeth/wizard_node.go
cmd/utils/flags.go
core/bench_test.go
core/block_validator.go
core/chain_makers.go
eth/backend.go
eth/config.go
eth/gasprice/gasprice.go
eth/gen_config.go
internal/ethapi/api.go
miner/miner.go
miner/stress_clique.go
miner/stress_ethash.go
miner/worker.go
miner/worker_test.go
params/denomination.go
params/protocol_params.go

core: safe indexer operation when syncing starts before the checkpoint
Comments: ensures safe indexer operation when syncing starts before the checkpoint. It prevents the indexer from rolling back before the checkpoint (which always fails because there is no chain data available) and verifies the actual synced section head to match the checkpoint section head when syncing reaches that point.

Changed files:
core/chain_indexer.go
light/lightchain.go

all: Indexer configurable
Comments: make chain indexers configurable, which will definitely help unit tests and avoid making thousands of blocks to generate an indexer element.
Besides, this pr fixes some testing issues in les package and can replace #17067 will a better and flexible method to ensure all indexers have generated enough index data.
Changed Files:
core/chain_indexer.go
eth/backend.go
eth/bloombits.go
les/api_backend.go
les/backend.go
les/bloombits.go
les/commons.go
les/handler.go
les/handler_test.go
les/helper_test.go
les/odr.go
les/odr_requests.go
les/odr_test.go
les/peer.go
les/request_test.go
les/server.go
light/lightchain.go
light/lightchain_test.go
light/odr.go
light/odr_test.go
light/odr_util.go
light/postprocess.go
light/trie_test.go
light/txpool_test.go
params/network_params.go

consensus/ethash: remove unnecessary type declaration
Comments: The *big.Int type declaration is not necessary, removed it.
Changed files:
consensus/ethash/consensus.go

core: fix typos in comment
Comments: fix typos in comment
Changed files:
core/tx_journal.go

vendor: github.com/rjeczalik/notify update to master
Comments: updates the notify package, so that it compiles under Go 1.10.4 on macOS.
Changed files:
vendor/github.com/rjeczalik/notify/watcher_fsevents_cgo.go
vendor/github.com/rjeczalik/notify/watcher_fsevents_go1.10.go
vendor/github.com/rjeczalik/notify/watcher_fsevents_go1.11.go
vendor/vendor.json

swarm/api: fix typo
Comments: Fix typos
Changed Files:
swarm/api/api.go

signer/storage: fix typo
Comments: Fix typos
Changed files:
signer/storage/aes_gcm_storage.go

miner: differentiate between uncle and lost block
Comments: If a block is mined, we wait 5 blocks and report wether a) it became canonical or b) became a fork --> explicitly differentiate
between included fork (uncle) and excluded fork(lost).

Fix a data race that could lead to corruption if multiple PoW solutions are found concurrently within the same mining cycle, but for different work tasks.
Mainly fixes two things:

1. state deep copy
2. secure trie deep copy

Fix a data corruption if a PoW solution is found to an older block within a single mining cycle .

Fix the timestamp and difficulty for recommitted transaction sets at the same block height .
Changed files:
miner/worker.go

Fix CPU mining for embedded in-process go-ethereum instances .
eth.Config.MinerThreads was ignored, this file was removed.
cmd, eth: clean up miner startup API, drop noop config field

Extend the logs to differentiate between reorged-but-included and reorged-and-excluded blocks .
If a block is mined, we wait 5 blocks and report wether a) it became canonical or b) became a fork --> explicitly differentiate
between included fork (uncle) and excluded fork(lost).

Changed files:
miner/unconfirmed.go
miner/unconfirmed_test.go
miner/worker.go

miner: commit state which is relative with sealing result
Comments:
Changed Files:
consensus/clique/clique.go
consensus/consensus.go
consensus/ethash/consensus.go
consensus/ethash/ethash_test.go
consensus/ethash/sealer.go
consensus/ethash/sealer_test.go
core/types/block.go
miner/worker.go
mobile/types.go

consensus, miner: stale block supporting.
Comments: mining pool will accept some stale but valid pow solutions since they can finally become uncle blocks --> ethash will forward all acceptable stale solutions to worker.
Note ethash will only accept the stale solution with a distance of no more than 7, otherwise, the solution will be discarded directly.
Changed files:
cmd/geth/main.go
cmd/geth/usage.go
cmd/utils/flags.go
consensus/clique/clique.go
consensus/consensus.go
consensus/ethash/algorithm_test.go
consensus/ethash/ethash.go
consensus/ethash/ethash_test.go
consensus/ethash/sealer.go
consensus/ethash/sealer_test.go
eth/api_tracer.go
eth/backend.go
eth/config.go
eth/gen_config.go
les/backend.go
miner/worker.go

core, trie: fix state log deep copy
Comments: This PR mainly fixes two things: state deep copy and secure trie deep copy.
Regarding the secure trie, the secure cache content (trie key's preimages) will be discarded for the copied trie in the current codebase, it will definitely introduce some trouble when we want to dump state.
Changed Files:
core/state/statedb.go

cmd, eth: clean up miner startup API, drop noop config field
Comments: the eth.Config.MinerThreads was ignored. This PR removes the field altogether. This PR moves all the thread handling logic into the ethereum.Start/StopMiner methods and simplifies the API to just call out to these.
Changed Files:
cmd/geth/main.go
cmd/utils/flags.go
eth/api.go
eth/backend.go
eth/config.go
eth/gen_config.go
miner/stress_clique.go
miner/stress_ethash.go

swarm/api/http: fixed resolver bug
Comments: This PR fixes a bug with resolving ENS names that was introduced as part of refactoring the swarm/api package.
Changed Files:
swarm/api/http/server.go

from bitconch-core.