Replace keccak256 with blake2 about bitconch-core HOT 7 CLOSED

@caesarchad Bro

Blake compare to Keccak 256, 512

from bitconch-core.

@luhuimao
My thoughts, create a new go file containing the above function(modify if necessary) and replace all occurrences of existing keccak256/512.

// Blake2b256 caluculates and returns the Blake2b hash of the input data.
func Blake2b256(data ...[]byte) []byte {
	
	// calculate the blake2b hash 
	hash, _ := blake2b.New256(nil)

	// write into hash
	for _, b := range data {
		hash.Write(b)
	}
	
	// return the sum 
	return hash.Sum(nil)
}

// Blake2b256Hash calculates and returns the Blake2b256 hash of the input data,
// converting it to an internal Hash data structure.
func Blake2b256Hash(data ...[]byte) (h common.Hash) {
	
	// calculate the blake2b hash 
	hash, _ := blake2b.New256(nil)

	// write into hash
	for _, b := range data {
		hash.Write(b)
	}
	
	// return the sum 
	hash.Sum(h[:0])

	return h
}

from bitconch-core.

@caesarchad
After my investigation, Blake2 offers better security and performance compared to keccak256, reasons as below:

• SHA256 was based on SHA1 (which is weak). BLAKE was based on
  ChaCha20 (which is strong).
• SHA256 has realistically feasible attacks against 31 out of 64
  rounds. BLAKE2 has no feasible attacks against more than 2 out of 10
  (BLAKE2s) or 2 out of 12 (BLAKE2b) rounds.
• BLAKE2 has security features which could be useful for us, such as
  protection against length-extension, a standard method of keying,
  "personalization tags" to guarantee domain separation, etc.
• BLAKE2 is more efficient than SHA256 in software on most
  platforms. For example, on ARM chips, it is usually about twice as
  efficient as SHA256 when hashing 64 bytes.
• BLAKE2 is the de facto standard hash function used by all of the
  skilled symmetric cryptographers working on things like Password
  Hashing Competition, new Proofs-of-Work such as Equihash,
  etc. Whatever Proof-of-Work function we choose, it'll probably turn
  out to come defined to use BLAKE2.

from bitconch-core.

@luhuimao excellent work!
I have updated the code #11 (comment)
, will do some unit test to check.

from bitconch-core.

@luhuimao
I have updated the scope of the code, please help to double-check. if anything is missing out, please let me know.

from bitconch-core.

@caesarchad bro update:
golang src files use crypto.Keccak256Hash, addition, total: 37

FYI, I got these results by running command

 "findstr /m /s  /i /C:"crypto.Keccak256hash"  *.* >E:\1.txt"

from bitconch-core.

@luhuimao
Push to BUS005 branch.

from bitconch-core.