Git Product home page Git Product logo

Comments (15)

schildbach avatar schildbach commented on July 28, 2024

device-2013-04-03-190224

from bitcoin.org.

saivann avatar saivann commented on July 28, 2024

Strangely, on Android at least, it is possible to scroll when the bubble overflow on the right side (it would work with Armory) but it doesn't work with the left side (Bitcoin-Qt).

Meanwhile as a simple workaround, it is possible to see the bubble by turning your mobile horizontally (landscape).

from bitcoin.org.

tcatm avatar tcatm commented on July 28, 2024

I'd suggest removing the popups completely and just list all the clients. Makes it much easier to see which client is available for an specific OS, too.

from bitcoin.org.

saivann avatar saivann commented on July 28, 2024

@tcatm : You mean, only show the mobile apps from the mobile website with no bubble, and keep the rest as it is for desktops?

from bitcoin.org.

tcatm avatar tcatm commented on July 28, 2024

Nope, just show a list (maybed with tabs for each category) of all apps.

from bitcoin.org.

saivann avatar saivann commented on July 28, 2024

I was afraid that this approach would either be limitative, or not scale well and become heavy loaded and less consistent (especially if we have more wallets in the future). It also would not allows us to explain each wallet category very well and we would miss explanations about webwallet, I think those are important for a new visitor. Since most wallet apps are available for all operating systems, I thought it was a greater priority to have a consistent layout that could scale with a clear division between each category.

from bitcoin.org.

schildbach avatar schildbach commented on July 28, 2024

Also, the un-hiding of web-wallets does not work on Chromium / Android. Nothing happens if I click on "OK".

from bitcoin.org.

saivann avatar saivann commented on July 28, 2024

This one should be fairly easy to fix. Thanks for reporting.

from bitcoin.org.

saivann avatar saivann commented on July 28, 2024

@schildbach Since you are currently testing, what happens if you replace all

  href="javascript:walletshow();" 

by

  href="#" onclick="walletshow();cancelEvent(event);"

in choose-your-wallet.html

from bitcoin.org.

schildbach avatar schildbach commented on July 28, 2024

AFAICT doesn't work. But better try it yourself - I'm not sure if my local environment can test this - e.g. the issue with the missing URL rewriting.

from bitcoin.org.

saivann avatar saivann commented on July 28, 2024

If forgot to mention that this fix targets the "impossible to un-hide the web-wallets" issue. Is it the issue you tested? If that's the case, I'm puzzled.. As it works well in default Android 2.3 browser and Chrome on desktop.

from bitcoin.org.

schildbach avatar schildbach commented on July 28, 2024

Yes, that's the one I tested. I just tried the old Android browser, which is still around on Android 4.2. On that browser, un-hiding works. However, the whole layout is broken because it is not detected as a mobile browser.

from bitcoin.org.

schildbach avatar schildbach commented on July 28, 2024

Firefox for Android is also not detected correctly.

from bitcoin.org.

saivann avatar saivann commented on July 28, 2024

I've just installed Firefox for Android, tested current bitcoin.org.. and it worked perfectly in my case..

I bet that it is related to the resolution of the device. Current CSS tries to detect mobile based on handheld or resolutions lower than 700px :

@media handheld, only screen and (max-device-width:700px) {

from bitcoin.org.

saivann avatar saivann commented on July 28, 2024

Meanwhile, there seems to be too much "apparently impossible to fix" issues for this page. Therefore, since its content is not as relevant on mobile and as suggested by a few, I choosed to hide this part of the website. Issues are described in the commit in case someone have genius ideas and want to work on this. But it seems rather complicate, especially because of the "display hidden wallet" part. 68d6e91

It might make more sense to auto-detect and show Bitcoin Wallet / Android or Blockchain / iPhone in the "Get started fast and easy" in the future.

from bitcoin.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.