Git Product home page Git Product logo

Comments (16)

lgatto avatar lgatto commented on June 5, 2024 1

@LiNk-NY @mtmorgan - the make_sticker function seems to be quite useful (to me, at least). I would rather move it to a package for convenience. Would you consider it fit for BiocStyle, for example, or should it get its own package?

from biocstickers.

GuangchuangYu avatar GuangchuangYu commented on June 5, 2024 1
p <- ggplot(aes(x = mpg, y = wt), data = mtcars) + geom_point()
p = p + theme_void() + theme_transparent()
make_sticker(p, "Bioconductor")

bioconductor

142d1f5 change the dimension according to https://twitter.com/robbie_bonelli/status/795211775679418372.

from biocstickers.

jorainer avatar jorainer commented on June 5, 2024 1

I would only make a package of the functionality to create the stickers and would not include the actual stickers or sticker functions into that package. 1) some stickers (mine ;) ) were made manually and 2) I would simply keep functionality (the function) and results (the stickers) separate.

from biocstickers.

lgatto avatar lgatto commented on June 5, 2024 1

I have created a sticker package with the make_sticker function.

from biocstickers.

GuangchuangYu avatar GuangchuangYu commented on June 5, 2024 1

I have some ideas to improve it and create a package separately for not breaking your existing codes.

see https://github.com/GuangchuangYu/hexSticker.

from biocstickers.

GuangchuangYu avatar GuangchuangYu commented on June 5, 2024

that's awesome. Thanks @lgatto

from biocstickers.

jorainer avatar jorainer commented on June 5, 2024

Very nice 👍 🥇

from biocstickers.

lgatto avatar lgatto commented on June 5, 2024

TODO

- [ ] Adjust dimensions to get an image of height 5cm, ready for printing.
- [ ] Fix hexagon not filling the full square; on the left side there is a small gap.

TODO list has been moved to sticker issue 1.

from biocstickers.

lgatto avatar lgatto commented on June 5, 2024

New defaults
bioconductor

from biocstickers.

GuangchuangYu avatar GuangchuangYu commented on June 5, 2024

I vote for new package, maybe BiocSticker. Developers can PR for their sticker_pkgname function and then we can have a package of reproducible sticker collections.

from biocstickers.

lgatto avatar lgatto commented on June 5, 2024

I vote for new package, maybe BiocSticker. Developers can PR for their sticker_pkgname function and then we can have a package of reproducible sticker collections.

Ok for a package; I would rather name it stickeR or sticker to make it more general.

If we push actual sticker creation functions in there, then this repo becomes obsolete. The advantage of an external package is that it easier for me to control what version I use for my sticker; otherwise, every change in the function (like 142d1f5, for example), possibly breaks stickers.

With respect to the package, having it on github allows to install versions based on SHA commit hashes; this enables me to keep using one consistently for different stickers, as long as I record which SHA I was using upon creation.

from biocstickers.

jorainer avatar jorainer commented on June 5, 2024

I realized that the hexagon is not filling the full square. On the left side there is a small gap. Could this be fixed?

from biocstickers.

jorainer avatar jorainer commented on June 5, 2024

@lgatto Is the function in the package different from the one we had here? I'm asking because the same code that generated this sticker https://github.com/jotsetung/BioC-stickers/blob/master/mzR/mzR.png now creates:
mzr

from biocstickers.

lgatto avatar lgatto commented on June 5, 2024

There have been a couple of PRs recently, but I think that the text size is also influenced by other parameters (at least that's what I observed yesterday, when preparing the pRoloc stickers). That why we need a package and the flexibility to install a use a specific SHA has to preserve old stickers, at least until we have a stable make_sticker.

from biocstickers.

GuangchuangYu avatar GuangchuangYu commented on June 5, 2024

This is because the units are in two different spaces (data and pixel).

from biocstickers.

jorainer avatar jorainer commented on June 5, 2024

Yup, I just reduced the size of the text - works now.

from biocstickers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.