Git Product home page Git Product logo

Comments (5)

dariusmb avatar dariusmb commented on September 3, 2024

I created a PR for this problem

from bingads-python-sdk.

eric-urban avatar eric-urban commented on September 3, 2024

@razvanbretoiu @dariusmb will you please clarify the requirement? The user_id in the auth request is NOT a Bing Ads system user ID. If you need the user ID for a Bing Ads User, you can call GetUser and set the UserId to nil/empty. If you need the Microsoft Account (MSA) user_id please clarify the use case. Thanks.

@qitia FYI

from bingads-python-sdk.

razvanbretoiu avatar razvanbretoiu commented on September 3, 2024

@eric-urban we need the Microsoft Account (MSA) thats why I can't use GetUser.

from bingads-python-sdk.

eric-urban avatar eric-urban commented on September 3, 2024

@razvanbretoiu @dariusmb @qitia for flexibility how about let's return the full response as JSON from the token request. Clients can parse the values they care about, whether returned today or added in the future. My concern about promoting "user_id" in OAuth tokens is that someone might confuse it with the Bing Ads User ID. I haven't heard of anyone needing the MSA user_id until now.

from bingads-python-sdk.

qitia avatar qitia commented on September 3, 2024

as @eric-urban suggested, we return the full response as JSON. This is released with version 12.0.1.

from bingads-python-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.