response undefined when error occurs. about node-binance-api HOT 6 CLOSED

Perhaps something like this would work

		signedRequest(base+endpoint, opt, function(error, response) {
			if ( !response ) {
				if ( callback ) callback(error, response);
				else console.error('Order() error:', error);
				return;
			}
			if ( typeof response.msg !== 'undefined' && response.msg === 'Filter failure: MIN_NOTIONAL' ) {
				console.error('Order quantity too small. See exchangeInfo() for minimum amounts');
			}
			if ( callback ) callback(error, response);
			else console.log(side+'('+symbol+','+quantity+','+price+') ',response);
		}, 'POST');

from node-binance-api.

Thanks. Looking in to this

from node-binance-api.

TypeError: Cannot read property 'msg' of undefined
/node_modules/node-binance-api/node-binance-api.js:143:25

/node_modules/node-binance-api/node-binance-api.js:143
if ( typeof response.msg !== 'undefined' && response.msg === 'Filter failure: MIN_NOTIONAL' ) {

from node-binance-api.

could be. please fix and i'll test.

from node-binance-api.

live in v0.4.3
jaggedsoft@b5bb192

from node-binance-api.

For anyone else reviewing this, it might be better to check if ( error ) instead, not sure the best way to handle this.

from node-binance-api.