Should the `JSONParserType` offer an optional `options` argument about freddy HOT 5 CLOSED

Good thinking; lots of questions raised. Exposing an option set would require that every parser implement every option, or that some mysteriously don't work. I don't like it.

from freddy.

Not necessarily. Right now we make NSJONSerialization conform to JSONParserType directly; we could wrap it up into something that took options, without exposing those options to other parsers. E.g.,

struct NSJSONSerializationWrapper: JSONParserType {
    private let options: NSJSONReadingOptions

    init(options: NSJSONReadingOptions = []) {
        self.options = options
    }

    static func createJSONFromData(data: NSData) throws -> JSON {
        return makeJSON(try NSJSONSerialization.JSONObjectWithData(data, options: options))
    }

    // makeJSON same as in our extension on NSJSONSerialization
}

Not very discoverable, but it'd do the trick.

from freddy.

Personally, I like @jgallagher's proposal because it at least exposes the options if they are needed. Without this, there is a chance that use of the NSJSONSerializationWrapper is a non-starter because I can't send it a certain configuration option, which I require. (It reminds me of registering cells for reuse in a table view but not being able to specify the cell style ... so you can't use the standard UITableViewCell styles with the register approach.)

from freddy.

This is a backwards compatible change, so it doesn't need to be decided prior to release. That said, a couple of bikeshedding options and what they'd look like to users:

• Wrapper struct - what would the name of this be? I'll throw NSJSONSerializationWithOptions out for now but am not a big fan of that name.

let json = try JSON(data: data, usingParser: NSJSONSerializationWithOptions([.AllowFragments]))

• Skip the wrapper struct and make NSJSONReadingOptions itself conform to JSONParserType:

let json = try JSON(data: data, usingParser: NSJSONReadingOptions([.AllowFragments]))

from freddy.

Closing due to inactivity and the general state of the repo.

from freddy.