Parsing issue when using directives about ngx-translate-extract HOT 6 CLOSED

Thanks.

A PR fixing the regexp in PipeParser is welcome!

from ngx-translate-extract.

I'm not sure how to support both:

<button [attr]="'Hello World' | translate"></button>
... and ...
<button [style.background]="'lime'">{{ 'Hello World' | translate }}</button>

... at the same time. Any ideas?

This is the current regexp: https://github.com/biesbjerg/ng2-translate-extract/blob/master/src/parsers/pipe.parser.ts#L18

from ngx-translate-extract.

I cannot make a PR right now, unfortunately.

But this works for the test cases I copied from your pipe-test.
I've added > to the 'except-group'.

https://regex101.com/r/wLb8us/2

from ngx-translate-extract.

Thanks!

Fixed in fcd37fd

from ngx-translate-extract.

This issue is still existing with services.

trans.get("You are expected at {{time}}", {time: moment.format('H:mm')}).subscribe(text => {

returns in:

"You are expected at {{time}}', {time: resDate.format('H:mm": "",

from ngx-translate-extract.

I can't reproduce. I added a test that is passing for me:

	it('should extract strings with params', () => {
		const contents = `
			@Component({ })
			export class AppComponent {
				public constructor(protected trans: TranslateService) { }
				public test() {
					trans.get("You are expected at {{time}}", {time: moment.format('H:mm')}).subscribe();
				}
			}
		`;
		const keys = parser.extract(contents, componentFilename).keys();
		expect(keys).to.deep.equal(['You are expected at {{time}}']);
	});

Also, the first string you provided in your comment uses a different parameter value than the extracted one, which leads me to believe it is another string you are having problems extracting?

from ngx-translate-extract.