Comments (2)
So the above PR is fairly minor. Only the full BIDS tests return warnings. All the individual checks return issues before they're separated into warning and errors. So tests on individual checks are already testing both.
I added warning assertions to the two semi-static dataset tests, but I'm unsure how best to tackle setting warning assertions for the test that loops through the example datasets and validates each one. Many of them have different numbers of warnings.
I can think of two options so far. We can create some sort of map that lists each dataset by name and the number of expected warnings or if it's possible/reasonable we could assert that the example datasets should not have any warnings and update them to match.
Let me know if you have any preferences or thoughts on addressing this issue.
from bids-validator.
Update merged.
from bids-validator.
Related Issues (20)
- github action to run bids-validator on bids-examples
- Validator requires echo entity to be immediately before "_bold.nii.gz" HOT 4
- deno 101: how to ship/run the "build"? HOT 7
- deno testing 101: deno_tests.yml is chronically red, "on purpose"? HOT 4
- deno: lost --config option? HOT 3
- deno run on a built bids-validator.js: Attempted to load JSON module without specifying "type" HOT 2
- Tests for some reason expect `/tmp/$USER` to exist? HOT 1
- deno: could --schema be made to take `src/schema` yaml tree as input? HOT 5
- IntendedFor links pointing into `derivatives/` directory fail HOT 2
- Update evalInitialColumns to account for recommended columns.
- Should we be relaxed about initial `/` for dataset-relative paths?
- [BUG] Validator isn't screaming when PET image files are lacking sidecar files HOT 1
- IntendedFor links pointing at `_meg.ds/` directories fail
- CITATION.cff support
- Bundle schema validator and legacy validator into Docker container
- Legacy validator permitting (i)EEG files without sidecars HOT 3
- New phenotype filename rule messes with filename rule suggestion heuristic.
- Implement allequal in expression language. HOT 2
- TSV column type check overhaul HOT 6
- No error/warning when IDs in `participant.tsv` do not match directory names HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bids-validator.