Not validating top-level JSONs that are inherited by scans in multiple session configuration about bids-validator HOT 8 CLOSED

I recreated a minimal dataset with the naming scheme you listed above and did not encounter this issue. The spec requires these properties to be defined in capital case instead of the more JSON-idiomatic camel-case (for example RepetitionTime is valid and repetitionTime isn't). Can you double check if your task-DMNTRACKINGTEST_bold.json follows the capital case convention? And if it does and you're still experiencing this issue are you willing/able to share the contents of task-DMNTRACKINGTEST_bold.json?

from bids-validator.

The task-DMNTRACKINGTEST_bold.json file does indeed follow capital case. If you want to take a look at it, it's located at http://s3.amazonaws.com/fcp-indi/data/Projects/RocklandSample/RawDataBIDS/Release6/task-DMNTRACKINGTEST_bold.json . In the meantime, I'll try re-running the validator to see if I can replicate the issue.

from bids-validator.

Thanks, I'm taking a look now.

from bids-validator.

Looks like the issue is caused by using single quotes for strings (the values for "FlipAngle" and "MagneticFieldStrength") in the JSON file. A lot of systems will coerce single quoted strings to double quoted but only doubles are listed in the JSON spec http://www.json.org/ so I'm questioning whether we should allow them or not.

You should have seen this error above the Repetition time and other warnings.

2: Not a valid JSON file. (code: 27)
    /task-DMNTRACKINGTEST_bold.json

Was this JSON file generated automatically by another program or written manually? If it's created by a popular system it might be a case for allowing single quotes.

@chrisfilo do you see any reason for allowing single quoted strings in JSON files?

from bids-validator.

Thanks @constellates. The JSON was created using Python's json module-
I'll try using double quotes to see if that solves the issue.

2016-01-04 13:02 GMT-05:00 constellates [email protected]:

Looks like the issue is caused by using single quotes for strings (the
values for "FlipAngle" and "MagneticFieldStrength") in the JSON file. A lot
of systems will coerce single quoted strings to double quoted but only
doubles are listed in the JSON spec http://www.json.org/ so I'm
questioning whether we should allow them or not.

You should have seen this error above the Repetition time and other
warnings.

2: Not a valid JSON file. (code: 27)
/task-DMNTRACKINGTEST_bold.json

Was this JSON file generated automatically by another program or written
manually? If it's created by a popular system it might be a case for
allowing single quotes.

@chrisfilo https://github.com/chrisfilo do you see any reason for
allowing single quoted strings in JSON files?

—
Reply to this email directly or view it on GitHub
https://github.com/INCF/bids-validator/issues/62#issuecomment-168753276.

from bids-validator.

@constellates let's stick to JSON spec and keep only double quotes.

from bids-validator.

Double quotes works! Thanks.

2016-01-04 13:38 GMT-05:00 Chris Filo Gorgolewski [email protected]
:

@constellates https://github.com/constellates let's stick to JSON spec
and keep only double quotes.

—
Reply to this email directly or view it on GitHub
https://github.com/INCF/bids-validator/issues/62#issuecomment-168762945.

from bids-validator.

No problem.

from bids-validator.