Comments (5)
@bhb not sure if this is also relevant but shouldnt the syntax error
above also show the let
part?
Currently it seems to be stripped away which puts away part of the context of the expression.
from expound.
@carocad Yes, I agree, it should show the let
part - that would make things much more clear.
Unfortunately, the data from spec doesn't currently include the function/macro name. It'd be great if this was fixed - please vote for https://dev.clojure.org/jira/browse/CLJ-2271 😄
Until the above bug is fixed, I'm considering adding a placeholder, so this would look like:
(<f> [a] ...)
^^^
... to indicate these are args to a macro. What do you think about the idea of using a placeholder? Does it help or just confuse things? Is <f>
a good enough placeholder? Or would you prefer something more verbose like <fn-or-macro>
? Something else?
from expound.
@bhb if I would have to choose between no macro info and placeholder I would choose no macro info. Since I am typing the code I can get a pretty rough idea of where the execution failed based on the rest of the info. I think that putting a placeholder would only confuse things since that is nowhere to be found in the code that the user wrote.
So far I have only encountered this problem for Clojure code since I almost dont use macros. With the inclusion of #44 the error gets so evident that it is very difficult to not identify where the problem is happening.
That might not be true for people that create and use lots of macros though. but I guess if they would have that problem they could report it here 😸
from expound.
@carocad Thanks for the feedback!
from expound.
The fix will be in the next release, currently in 0.7.1-SNAPSHOT.
from expound.
Related Issues (20)
- Error reports returned as :cause string in an exception when produced by instrumentation within generative testing HOT 11
- allow passing options map to expound/expound-str HOT 1
- Improve grouping of spec errors HOT 2
- Unnecessary dependency on `cider-nrepl` HOT 1
- Regression of #3 HOT 4
- Easier editing of error messages
- `printer` has invalid spec HOT 2
- "Cannot convert path" on instrumentation failures in the wild HOT 4
- (cljs.spec.test.alpha/instrument) breaks expound due to wrong arity HOT 4
- should expound work anywhere s/explain works? - clojurescript error HOT 7
- Error in :ret check when using with Orchestra 2020.07.12-1 HOT 5
- Internal error in `lift-singleton-groups` when having a datomic db value in fn args HOT 13
- Crash bug when printing, if a datomic db is present and the spec fails HOT 19
- Feature inquiry: a convenience function for validating a value against a spec HOT 4
- Wrapped `s/keys` does not properly display unqualified keyword specs HOT 5
- ClassCastException from `expound-str` when running in AWS Lambda HOT 9
- Small *print-length* and/or *print-level* sometimes yield NPE HOT 5
- PersistentList cannot be cast to class Named HOT 3
- proposal : defmsg equivalent for arbitrary predicates HOT 15
- optional include location of the spec error in the message. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from expound.