does not work with `s/or` and multiple spec maps about expound HOT 8 CLOSED

@bmabey Thanks very much for reporting this!

This is an internal check that unfortunately cannot be resolved by your client code - it means that Expound incorrectly assumes that all problems refer to the same piece of invalid data. If that's not true, Expound is going to have a bug anyway, so this assert catches the problem early. That's why the error message isn't too good - the only resolution is to report the bug, rather than change your code 😄 .

I think the error message here could be improved since the vanilla assert message is not helpful.

That's a good idea! I could at least add a message asking users to report the bug, so they don't wonder how to resolve it.

All that said, you've found a bug in Expound. If possible, can you share the code you used to trigger this assert? Thanks!

from expound.

The bug occurs when using s/or. Here is a reduced and contrived example that will trigger it:

(s/def :example.place/city string?)
(s/def :example.place/state string?)
(s/def :example/place (s/keys :req-un [:example.place/city :example.place/state]))

(s/def :example.person/first-name string?)
(s/def :example.person/last-name string?)
(s/def :example/person (s/keys :req-un [:example.person/first-name :example.person/last-name]))

(s/def :example/person-or-place  (s/or :person :example/person
                                       :place :example/place))

(s/explain :example/person-or-place {}) ;; works fine
(expound/expound :example/person-or-place {}) ;; blows up

from expound.

@bmabey Thanks for the repro! I'll fix ASAP

from expound.

@bmabey Thanks again for reporting this. Can you try 0.4.1-SNAPSHOT and see if it works for you?

from expound.

@bmabey Does this fix your issue? You can try it out by using 0.4.1-SNAPSHOT. Thanks!

from expound.

It is hard for me to reproduce the error in my system now but if the above use case is handled I think this will prevent it from happening again. Thanks!

from expound.

@bmabey No worries, thanks for the feedback!

from expound.

@bmabey I've released Expound 0.5.0, which includes this fix.

from expound.