Expound providing clojurescript? about expound HOT 10 CLOSED

@olivergeorge OK, I think I've got a simple fix for this. I think eventually I'll take @danielcompton's suggestion to reconfigure the project to not put compiled JS in resources, but for now, I've updated the :clean-targets option in project.clj.

Would you mind confirming the fix?

1. git clone [email protected]:bhb/expound.git
2. cd expound
3. git checkout cursive-bug
4. lein install
5. In your test project, include [expound "0.2.1-SNAPSHOT"]

from expound.

Thanks for reporting this!

It looks like it's a known Cursive bug but it does not appear to happen with all .cljc files (for instance, I could not reproduce it with Integrant).

I'll look into this more. If there is something I can change in the project.clj file that fixes this without breaking other scenarios, I'm happy to try it.

from expound.

I think this is because the jar includes compiled test files in it? https://repo.clojars.org/expound/expound/

from expound.

@danielcompton Thanks very much for the idea! That does indeed look suspicious. I'll look into how to exclude this directory when doing lein deploy clojars

from expound.

Because they are in resources/public this would be included by default. You can use :jar-exclusions, or maybe compile the CLJS into a different directory?

from expound.

@danielcompton Hm, I'm considering my options here. I put everything in resources originally so that I could connect to Figwheel in the browser to access a CLJS REPL, but it does seem cleaner to compile all CLJS for tests in, say target.

OTOH, just using :jar-exclusions would fix this for now, even if it's a bit of a hacky workaround

from expound.

@danielcompton I can confirm that excluding these files from the jar fixes the issue. Thanks very much for the idea, that would not have occurred to me!

I'll weigh my options and figure out a good fix for this ASAP.

from expound.

@bhb Confirmed. 0.2.1-SNAPSHOT resolves the problem.

from expound.

@olivergeorge Thanks for testing!

from expound.

I've released 0.2.1 to address this.

from expound.