The expound/def macro does not work in ClojureScript about expound HOT 9 CLOSED

@arichiardi Ah, yes, I bet you're right. Thanks for reporting this!

from expound.

@arichiardi As a temporary workaround, can you use the normal s/def from spec and then use expound/defmsg to add a message?

https://bhb.github.io/expound/expound.alpha.html#var-defmsg

from expound.

Yep doing that now thank you 😉

from expound.

@arichiardi What tools are you using to compile the CLJS? I'm not able to reproduce this error, but I suspect it's because my test runner is loading a lot of stuff, so perhaps a more isolated environment would reveal the issue.

from expound.

@arichiardi Ah, nevermind, I was able to repro using cljs.main

from expound.

Oh cool yeah, I did not have too much time for this small PR - you know lazy devs just sometimes settle for the workaround 😄 - but I was planning to give it a go as well

from expound.

Update: I worked on this for awhile without a satisfactory resolution. The issue is that it's hard to determine if we want to use cljs.spec.alpha or clojure.spec.alpha.

If you are executing Clojure code, that could mean you want to use clojure.spec.alpha OR it could mean you're doing the macro-expansion phase when using CLJS, and really want to expand to cljs.spec.alpha.

I considered doing a hack where I try to guess whether or not we want cljs, but that seems like it will create more headaches. I could also create new namespaces, one specifically for CLJ and another for CLJS, each of which have their own version of the def macro.

A related issue is that def doesn't really work like the normal def, because it doesn't make sense to attach a message to a symbol, only to a keyword e.g. :my-app/my-spec #101

Because of all this, I'm going to pause on this for now. I'm inclined to just remove the def macro for the beta and only support defmsg, which is marginally more code for the user, but a lot simpler. I'll think more about this 😄

from expound.

Thanks @bhb for the analysis and TBH that does not bother me too much so given the complicated hack this feature would resolve in I am quite happy that I am not using it 😄

I have got the feeling that breakage would be easy with future ClojureScript versions.

from expound.

👍

from expound.