consider shorting down error message on sequence failure about expound HOT 10 OPEN

Thanks for submitting this! I agree, the output is quite verbose in cases like this. I’ll think more about how I can shorten the output without losing useful context.

from expound.

@bhb if I may add. Would it also be possible to add a bit more context to the error report?

In this particular case, :mode "transit" is a key-value pair that is repeated in several steps so the report showing only the failing value is not enough to know exactly which part is failing.

For that I had to switch back to Clojure explain since there I was able to see exactly which values where failing :(

from expound.

Thanks for that additional information! Yes, I’ll also look at how to best add more context in this case.

FWIW, if Expound is omitting too much information, you can use “custom-printer” with “:show-valid-values?” set to true. The API is a bit inconsistent right now (I plan to simplify things for the beta) so let me know if you have any trouble getting this working.

from expound.

@carocad Here's the code for that:

(binding [s/*explain-out* (expound/custom-printer {:show-valid-values? true})]
  (s/explain (s/coll-of int?) [1 2 :3]))
;;-- Spec failed --------------------
;;
;;  [1 2 :3]
;;       ^^
;;
;;should satisfy
;;
;;  int?
;;
;;-------------------------
;;Detected 1 error

I realize that's not intuitive, but I'll be making this easier at some point. Until then, it may be easiest to wrap it up in a function. Hope that helps!

from expound.

@bhb Thanks for the info

Using show-valid-values together with the figwheel-theme do improve the situation a bit. However, now the output is gigantic (due to the size of the response that I have) :(

I think that ideally the failing value should show a bit of the context around (enough to know where the problem is) but not the complete datastructure; otherwise the failing value would get lost among the noise.

I know that is a very hard thing to do, though :/

PS: I avoided pasting the error message here, so please let me know if it would help you somehow

from expound.

Yes, it’s a bit tricky. Thanks for letting me know about your use case . It’s very helpful to know which cases need improvement. I’ll think more about this.

from expound.

@bhb i just had an idea about how to approach this problem.

Instead of using 'show valid values' I think the concept of depthwould be more appropriate. Basically instead of guessing how much context does a user need to understand the problem, let the user directly tell you.

This is (not by surprise) the same way that most Clojure stacktrace libraries work since those also contain lots of data.

Hope it helps :)

from expound.

Ah, that’s a good idea, thanks!

from expound.

I'm also experiencing the same issue as @carocad and my hacked-together solution was simple: capture the printed string from expound/custom-printer with with-out-string, search for empty lines with the following regex:

#"(?<=\n)\s+\.\.\.\n"

and replace each matching string with an empty string. It's a decent solution for my limited use-case, but ideally a similar regex replace would be implemented in the printer itself.

from expound.

@kelvinqian00 Thanks for posting this workaround! I agree this is not ideal. I’m thinking about ways to make this behavior optional.

from expound.