Comments (12)
@anuprulez Thanks for exposing the issue. My intuition is that changes of Galaxy's tool infrastructure caused the issue. I will look deep into it soon.
from galaxytools.
@anuprulez Unfortunately, I couldn't reproduce the issue shown in the shared history. I have correct list of parameters in the dropdown in my local instance. One thing worth mentioning: use only the list in the Search list
, having parameter name in the front, like selectkbest__k: [5880, 5890, 5895, 5900]
, would lead to failure.
from galaxytools.
As wrapped here https://github.com/bgruening/galaxytools/blob/master/tools/sklearn/search_model_validation.xml#L11-L17, lines starting with @
should be selected to be search parameters, i.e., showing as the dropdown options. The EU instance seems to do the opposite, excluding lines having @
. I have no idea what causes that, since I can't reproduce the issue elsewhere.
from galaxytools.
@qiagu thanks a lot for looking into it. I found a fix here: #1232
Without this change, most of the tool tests (that are expected to pass) were failing in my local instance. Two changes worked: either removing the entire attribute startswith="@"
or adding quotes for @: startswith=" '@' "
. I chose the latter option. I hope it works on the EU server. It seems to be related to parsing of special symbols I guess but not 100% sure.
from galaxytools.
Adding quotes to @ symbol did not work, unfortunately. But, removing it did and the tests are now passing. Removing it will add a few extra params in the list of estimator params of which the most we already show using @ as a startwith filter. It looks like there is some issue with parsing of this special symbol on EU server in the tool form, not 100% sure though.
from galaxytools.
Same issue on Galaxy Main as well. We should keep this issue open until it is fixed
from galaxytools.
Ha, the startswith
issue got fixed 29 days ago.
See: galaxyproject/galaxy@d642ce3
from galaxytools.
Do you want to ask for a backport?
from galaxytools.
My bad. I'd correct myself. The issue seems to be caused by the commit 29 days ago. We may need to revert the change.
galaxyproject/galaxy@d642ce3#diff-7a49a06712755de974dbcb43a317151e9ceee2af1e58914e28f2f4c7de9bdf9aL648-R648
from galaxytools.
I guess you need to open an issue then.
ping @bernt-matthias we well.
Thanks @qiagu for finding this.
from galaxytools.
As far as I see this repo is using 21.05 for testing PRs. So it should not be affected by galaxyproject/galaxy#14332 which was for 22.01, or?
Anyway, galaxyproject/galaxy#14332 brought the code in line with the docs. In the Galaxy tool xml docs you will find: startswith: Ignore lines starting with the given string
. Unfortunately that was never what was implemented in Galaxy. So I changed the code. As alternative we might revert the code change (ie fix) the docs.
Edit: Actually the docs were wrong (just added approx a year ago .. but the code is approx 15 years old)
from galaxytools.
Will be fixed in galaxyproject/galaxy#14440
from galaxytools.
Related Issues (20)
- License HOT 1
- Chemfp not found
- add repeat elements to tp_find_and_replace HOT 3
- Add more information to the help section. HOT 1
- Salmon doesn't work correctly with paired-end reads
- cut tool improvements HOT 1
- Split file to collection to tool fails with >1024 files HOT 8
- Update or replace link in help section of tp_awk_tool HOT 1
- Integration of a few BioModels (ML models)
- agat_sp_keep_longest_isoform.pl needed
- Many tools specify `format="text"` as data inputs or outputs
- Genbank file is not optional HOT 4
- New version of grep fails if pattern isn't found HOT 1
- Viz plugin requiring multiple datasets as input
- `Split file` doesn't include header in last dataset when called on rows HOT 3
- imagej2 enhance contrasts fails HOT 5
- MitoHiFi defaulting to animal data HOT 1
- Blobtoolkit can have trouble parsing raw Diamond results
- CPAT tool options HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from galaxytools.